From 1d6768284068be0b250b3e313d86024441026808 Mon Sep 17 00:00:00 2001 From: pyrQ <30827955+pyrQ@users.noreply.github.com> Date: Sun, 27 Oct 2024 13:28:31 +0200 Subject: [PATCH 1/5] Update Duel.SSet description and return type --- api/functions/Duel/SSet.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/api/functions/Duel/SSet.yml b/api/functions/Duel/SSet.yml index 6e1d63b0..bc6f8f1c 100644 --- a/api/functions/Duel/SSet.yml +++ b/api/functions/Duel/SSet.yml @@ -2,7 +2,7 @@ name: SSet namespace: Duel description: >- - A player Sets a cards(s) (Card|Group target) to the Spell/Trap Card Zone on target_player's field, if confirm is true, the card(s) set are revealed - for confirmation - to the opponent. + A player Sets a cards(s) (Card|Group target) to the Spell/Trap Card Zone on target_player's field, if confirm is true, the card(s) set are revealed - for confirmation - to the opponent. Returns the number of cards successfully Set. status: index: stable parameters: @@ -21,4 +21,7 @@ parameters: description: (To be added) required: false defaultValue: true +returns: + - type: [ int ] + description: (To be added) tags: [ under-construction ] From 1a5102542d80c01bd5b709c7159ec744cbf7260b Mon Sep 17 00:00:00 2001 From: pyrQ <30827955+pyrQ@users.noreply.github.com> Date: Sun, 27 Oct 2024 13:33:27 +0200 Subject: [PATCH 2/5] Add descriptions --- api/functions/Duel/SSet.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/api/functions/Duel/SSet.yml b/api/functions/Duel/SSet.yml index bc6f8f1c..aa67d6bc 100644 --- a/api/functions/Duel/SSet.yml +++ b/api/functions/Duel/SSet.yml @@ -8,20 +8,20 @@ status: parameters: - name: player type: [ int ] - description: (To be added) + description: The player that is Setting the Spells/Traps. - name: targets type: [ Card, Group ] - description: (To be added) + description: The Spells/Traps that will be Set. - name: target_player type: [ int ] - description: (To be added) + description: The player in whose field the Spells/Traps will be Set. required: false - name: confirm type: [ bool ] - description: (To be added) + description: Determines whether the Set cards will be shown to the opponent or not after being Set. required: false defaultValue: true returns: - type: [ int ] - description: (To be added) + description: The number of cards successfully Set. tags: [ under-construction ] From dd8afd6ab25ef3d43dde5117d3910bcc517adba6 Mon Sep 17 00:00:00 2001 From: pyrQ <30827955+pyrQ@users.noreply.github.com> Date: Sun, 27 Oct 2024 13:48:57 +0200 Subject: [PATCH 3/5] empty tag list --- api/functions/Duel/SSet.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/functions/Duel/SSet.yml b/api/functions/Duel/SSet.yml index aa67d6bc..6659e265 100644 --- a/api/functions/Duel/SSet.yml +++ b/api/functions/Duel/SSet.yml @@ -24,4 +24,4 @@ parameters: returns: - type: [ int ] description: The number of cards successfully Set. -tags: [ under-construction ] +tags: [ ] From 57041378320e158ce05bfe759fac7d8c67767f69 Mon Sep 17 00:00:00 2001 From: pyrQ <30827955+pyrQ@users.noreply.github.com> Date: Mon, 28 Oct 2024 12:59:12 +0200 Subject: [PATCH 4/5] Further improve the various descriptions --- api/functions/Duel/SSet.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/api/functions/Duel/SSet.yml b/api/functions/Duel/SSet.yml index 6659e265..65656390 100644 --- a/api/functions/Duel/SSet.yml +++ b/api/functions/Duel/SSet.yml @@ -2,23 +2,23 @@ name: SSet namespace: Duel description: >- - A player Sets a cards(s) (Card|Group target) to the Spell/Trap Card Zone on target_player's field, if confirm is true, the card(s) set are revealed - for confirmation - to the opponent. Returns the number of cards successfully Set. + Sets a card(s) to the Spell & Trap Card Zone or Field Zone. Can be used to Set Spells/Traps, as well as monsters with an effect that allows them to be Set in the Spell & Trap Zone (e.g. the "Artifact" monsters). status: index: stable parameters: - name: player type: [ int ] - description: The player that is Setting the Spells/Traps. + description: The player that is Setting the card(s). - name: targets type: [ Card, Group ] - description: The Spells/Traps that will be Set. + description: The card(s) that will be Set. - name: target_player type: [ int ] - description: The player in whose field the Spells/Traps will be Set. + description: The player in whose field the card(s) will be Set. required: false - name: confirm type: [ bool ] - description: Determines whether the Set cards will be shown to the opponent or not after being Set. + description: Determines whether the Set card(s) will be shown to the opponent or not after being Set. required: false defaultValue: true returns: From 42e6dd92f75a9e1937d1c4359ec6d73dd5fff160 Mon Sep 17 00:00:00 2001 From: pyrQ <30827955+pyrQ@users.noreply.github.com> Date: Mon, 28 Oct 2024 14:07:12 +0200 Subject: [PATCH 5/5] add target_player default value --- api/functions/Duel/SSet.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/api/functions/Duel/SSet.yml b/api/functions/Duel/SSet.yml index 65656390..d0e08dde 100644 --- a/api/functions/Duel/SSet.yml +++ b/api/functions/Duel/SSet.yml @@ -16,6 +16,7 @@ parameters: type: [ int ] description: The player in whose field the card(s) will be Set. required: false + defaultValue: player - name: confirm type: [ bool ] description: Determines whether the Set card(s) will be shown to the opponent or not after being Set.