Fix out of memory error with very large RetentionTimes table #3389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, always read retention times from database.
|
Score being a double also seems like overkill to me. |
…k/20250306_BlibOutOfMemory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mike has a .blib file with 60 million rows in the RetentionTimes table.
That .blib file was hitting an OutOfMemoryException in "BiblioSpecLiteLibrary.CreateCache" because that method uses a MemoryStream, and the MemoryStream was more than 2 billion bytes.
This pull request fixes the OutOfMemoryException by writing the MemoryStream out to disk as soon as it grows to larger than 10MB.
If it is not possible to write to disk (because the folder is read-only) then it will keep the entire cache file in memory so the user will still be able to use the .blib file (so long as the cache file is not larger than 2GB).
Next version we should get rid of the .slc file.
I have some ideas about how to speed up reading from the SQLite database using multiple threads so that there won't be any speed improvement having a cache file.