Skip to content

Commit dd77530

Browse files
committed
update examples to use the preferred NewDocumentFromReader approach
1 parent a86ea07 commit dd77530

File tree

2 files changed

+28
-5
lines changed

2 files changed

+28
-5
lines changed

README.md

+16-4
Original file line numberDiff line numberDiff line change
@@ -95,15 +95,27 @@ package main
9595
import (
9696
"fmt"
9797
"log"
98+
"net/http"
9899

99100
"github.com/PuerkitoBio/goquery"
100101
)
101102

102103
func ExampleScrape() {
103-
doc, err := goquery.NewDocument("http://metalsucks.net")
104-
if err != nil {
105-
log.Fatal(err)
106-
}
104+
// Request the HTML page.
105+
res, err := http.Get("http://metalsucks.net")
106+
if err != nil {
107+
log.Fatal(err)
108+
}
109+
defer res.Body.Close()
110+
if res.StatusCode != 200 {
111+
log.Fatalf("status code error: %d %s", res.StatusCode, res.Status)
112+
}
113+
114+
// Load the HTML document
115+
doc, err := goquery.NewDocumentFromReader(res.Body)
116+
if err != nil {
117+
log.Fatal(err)
118+
}
107119

108120
// Find the review items
109121
doc.Find(".sidebar-reviews article .content-block").Each(func(i int, s *goquery.Selection) {

example_test.go

+12-1
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,25 @@ package goquery_test
33
import (
44
"fmt"
55
"log"
6+
"net/http"
67

78
"github.com/PuerkitoBio/goquery"
89
)
910

1011
// This example scrapes the reviews shown on the home page of metalsucks.net.
1112
func Example() {
13+
// Request the HTML page.
14+
res, err := http.Get("http://metalsucks.net")
15+
if err != nil {
16+
log.Fatal(err)
17+
}
18+
defer res.Body.Close()
19+
if res.StatusCode != 200 {
20+
log.Fatalf("status code error: %d %s", res.StatusCode, res.Status)
21+
}
22+
1223
// Load the HTML document
13-
doc, err := goquery.NewDocument("http://metalsucks.net")
24+
doc, err := goquery.NewDocumentFromReader(res.Body)
1425
if err != nil {
1526
log.Fatal(err)
1627
}

0 commit comments

Comments
 (0)