Skip to content

Commit 0ae8bf7

Browse files
committed
Solve review comments
1 parent a62f677 commit 0ae8bf7

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed

lean/click.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
from lean.models.logger import Option
2424
from lean.models.errors import AuthenticationError
2525

26-
import tempfile
27-
2826

2927
def get_whoami_message() -> str:
3028
"""
@@ -61,7 +59,7 @@ def get_whoami_message() -> str:
6159

6260
return f"logged in as {member.name} ({member.email})"
6361

64-
def get_disk_space_info(path: Path) -> str:
62+
""" def get_disk_space_info(path: Path) -> str:
6563
import os
6664
try:
6765
if os.name == 'posix': # macOS y Linux
@@ -81,7 +79,7 @@ def get_disk_space_info(path: Path) -> str:
8179
f"Free: {free / (1024 ** 3):.2f} GB"
8280
)
8381
except Exception as e:
84-
return f"Error getting disk space: {str(e)}"
82+
return f"Error getting disk space: {str(e)}" """
8583

8684
class VerboseOption(ClickOption):
8785
def __init__(self, *args, **kwargs):
@@ -156,8 +154,10 @@ def _parse_verbose_option(ctx: Context, param: Parameter, value: Optional[bool])
156154
docker_version = "Not installed"
157155

158156
try:
157+
import tempfile
159158
temp_dir = Path(tempfile.gettempdir()).resolve()
160-
space_info = get_disk_space_info(temp_dir)
159+
space_info = ""
160+
#space_info = get_disk_space_info(temp_dir)
161161
except:
162162
temp_dir = ""
163163
space_info = ""

lean/components/util/temp_manager.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,16 @@
1212
# limitations under the License.
1313

1414
from pathlib import Path
15+
from lean.components.util.logger import Logger
1516

1617
class TempManager:
1718
"""The TempManager class provides access to temporary directories."""
1819

19-
def __init__(self) -> None:
20+
def __init__(self, logger: Logger) -> None:
2021
"""Creates a new TempManager instance."""
2122
self._temporary_directories = []
2223
self.delete_temporary_directories_when_done = True
24+
self._logger = logger
2325

2426
def create_temporary_directory(self) -> Path:
2527
"""Returns the path to an empty temporary directory.
@@ -29,6 +31,7 @@ def create_temporary_directory(self) -> Path:
2931
from tempfile import mkdtemp
3032
path = Path(mkdtemp(prefix="lean-cli-"))
3133
self._temporary_directories.append(path)
34+
self._logger.debug(f"Created temporary directory: {path}")
3235
return path
3336

3437
def delete_temporary_directories(self) -> None:

lean/container.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def initialize(self,
6868
self.platform_manager = PlatformManager()
6969
self.task_manager = TaskManager(self.logger)
7070
self.name_generator = NameGenerator()
71-
self.temp_manager = TempManager()
71+
self.temp_manager = TempManager(self.logger)
7272
self.xml_manager = XMLManager()
7373
self.http_client = HTTPClient(self.logger)
7474

@@ -211,4 +211,4 @@ def manage_docker_image(self, image: Optional[str], update: bool, no_update: boo
211211
return engine_image, container_module_version, project_config
212212

213213

214-
container = Container()
214+
container = Container()

0 commit comments

Comments
 (0)