Solve review comments

Author: JosueNina

lean/click.py

@@ -23,8 +23,6 @@
 from lean.models.logger import Option
 from lean.models.errors import AuthenticationError
 
-import tempfile
-
 
 def get_whoami_message() -> str:
     """
@@ -62,17 +60,10 @@ def get_whoami_message() -> str:
     return f"logged in as {member.name} ({member.email})"
 
 def get_disk_space_info(path: Path) -> str:
-    import os
+    import shutil
     try:
-        if os.name == 'posix':  # macOS y Linux
-            stat = os.statvfs(path)
-            total = stat.f_blocks * stat.f_frsize
-            free = stat.f_bfree * stat.f_frsize
-            used = total - free
-        else:  # Windows
-            import shutil
-            usage = shutil.disk_usage(path)
-            total, used, free = usage.total, usage.used, usage.free
+        usage = shutil.disk_usage(str(path))
+        total, used, free = usage.total, usage.used, usage.free
 
         return (
             f"Space in temporary location - "
@@ -156,7 +147,7 @@ def _parse_verbose_option(ctx: Context, param: Parameter, value: Optional[bool])
             docker_version = "Not installed"
 
         try:
-            temp_dir = Path(tempfile.gettempdir()).resolve()
+            temp_dir = container.temp_manager.create_temporary_directory().parent
             space_info = get_disk_space_info(temp_dir)
         except:
             temp_dir = ""

lean/components/util/temp_manager.py

@@ -12,14 +12,16 @@
 # limitations under the License.
 
 from pathlib import Path
+from lean.components.util.logger import Logger
 
 class TempManager:
     """The TempManager class provides access to temporary directories."""
 
-    def __init__(self) -> None:
+    def __init__(self, logger: Logger) -> None:
         """Creates a new TempManager instance."""
         self._temporary_directories = []
         self.delete_temporary_directories_when_done = True
+        self._logger = logger
 
     def create_temporary_directory(self) -> Path:
         """Returns the path to an empty temporary directory.
@@ -29,6 +31,7 @@ def create_temporary_directory(self) -> Path:
         from tempfile import mkdtemp
         path = Path(mkdtemp(prefix="lean-cli-"))
         self._temporary_directories.append(path)
+        self._logger.debug(f"Created temporary directory: {path}")
         return path
 
     def delete_temporary_directories(self) -> None:

lean/container.py

@@ -68,7 +68,7 @@ def initialize(self,
         self.platform_manager = PlatformManager()
         self.task_manager = TaskManager(self.logger)
         self.name_generator = NameGenerator()
-        self.temp_manager = TempManager()
+        self.temp_manager = TempManager(self.logger)
         self.xml_manager = XMLManager()
         self.http_client = HTTPClient(self.logger)
 
@@ -211,4 +211,4 @@ def manage_docker_image(self, image: Optional[str], update: bool, no_update: boo
         return engine_image, container_module_version, project_config
 
 
-container = Container()
+container = Container()

tests/components/docker/test_lean_runner.py

@@ -87,7 +87,7 @@ def create_lean_runner(docker_manager: mock.Mock) -> LeanRunner:
                       docker_manager,
                       module_manager,
                       project_manager,
-                      TempManager(),
+                      TempManager(logger),
                       xml_manager)
 
 

tests/components/util/test_temp_manager.py

@@ -10,12 +10,12 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-
 from lean.components.util.temp_manager import TempManager
+from unittest import mock
 
 
 def test_create_temporary_directory_creates_empty_directory() -> None:
-    temp_manager = TempManager()
+    temp_manager = TempManager(mock.Mock())
 
     path = temp_manager.create_temporary_directory()
 
@@ -24,13 +24,13 @@ def test_create_temporary_directory_creates_empty_directory() -> None:
 
 
 def test_create_temporary_directory_creates_new_directory_every_time() -> None:
-    temp_manager = TempManager()
+    temp_manager = TempManager(mock.Mock())
 
     assert temp_manager.create_temporary_directory() != temp_manager.create_temporary_directory()
 
 
 def test_delete_temporary_directories_deletes_all_previously_created_directories() -> None:
-    temp_manager = TempManager()
+    temp_manager = TempManager(mock.Mock())
 
     paths = []
     for i in range(5):