Fix/token-validation #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipesouza91
requested review from
emerson-oliveira,
htamagnus and
clintonbrito
|
emerson-oliveira
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sobre o Fix:
O middleware de autenticação só estava validando os tokens gerados pela integração junto ao Clerk. Ao tentar fazer a autenticação com um token gerado pela cadastro via Back-End do TVM, o mesmo retornava token invalido.
Realizado o fix fazendo que o middliware de Authentication, receba como dependência um array de TokenValidation, caso o token passe em alguma dessas validações o mesmo segue o fluxo normal, em caso de erro e retornado erro de autenticação.
Refatorado serviço de UserWithEmailService, para ao realizar o cadastro de um usuário pela aplicação, gerar um pré-cadastro na tabela user, e a vinculação o id da tabela userWithEmail para o campo externalUserId, da tabela de user. Pois esse registro é necessário para a continuidade do cadastro do usuário na plataforma.