From de7c247bef66ee42336b51ae8ad5dba331e48cf3 Mon Sep 17 00:00:00 2001
From: boredcoder411 <taamarcos@gmail.com>
Date: Sun, 11 Aug 2024 18:48:43 +0200
Subject: [PATCH] Added format! macro for performance and readability

---
 src/main.rs | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/src/main.rs b/src/main.rs
index c148c70..dcaedcd 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -9,7 +9,9 @@ struct PlistQuery {
     fetchurl: String,
 }
 
-static PLIST_TEMPLATE: &str = r#"<?xml version="1.0" encoding="UTF-8"?>
+async fn generate_plist(query: web::Query<PlistQuery>) -> impl Responder {
+    let plist_xml = format!(
+        r#"<?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
 <dict>
@@ -39,14 +41,12 @@ static PLIST_TEMPLATE: &str = r#"<?xml version="1.0" encoding="UTF-8"?>
         </dict>
     </array>
 </dict>
-</plist>"#;
-
-async fn generate_plist(query: web::Query<PlistQuery>) -> impl Responder {
-    let plist_xml = PLIST_TEMPLATE
-        .replace("{bundleid}", &query.bundleid)
-        .replace("{version}", &query.version)
-        .replace("{name}", &query.name)
-        .replace("{fetchurl}", &query.fetchurl);
+</plist>"#,
+        bundleid = query.bundleid,
+        version = query.version,
+        name = query.name,
+        fetchurl = query.fetchurl
+    );
 
     HttpResponse::Ok()
         .content_type("application/octet-stream")
@@ -63,3 +63,4 @@ async fn main() -> std::io::Result<()> {
     .run()
     .await
 }
+