Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.21 #271

Merged
merged 26 commits into from
Jun 19, 2024
Merged

Update to 1.21 #271

merged 26 commits into from
Jun 19, 2024

Conversation

DrexHD
Copy link
Contributor

@DrexHD DrexHD commented Jun 13, 2024

Things to specifically look into:

  • Kotlin has been bumped to 2.0.0 (could not identify any changes that need to be made)
  • Identifier constructors have been private'd causing some problems with konf. Applied a workaround using a wrapper to provide a constructor for the library (couldn't figure out any better solution). Marked with // TODO 1.21
  • Enchantments got reworked and frost walker is now implemented using ReplaceDiskEnchantmentEffect. It is now impossible to know if the blocks have been placed by frost walker or a custom datapack enchantment, also marked with // TODO 1.21

@DrexHD DrexHD requested a review from a team as a code owner June 13, 2024 20:42
@BenCat07
Copy link

BenCat07 commented Jun 15, 2024

Any new Identifier(...) can simply be replaced with Identifier.of(...)

can just search and replace new Identifier( -> Identifier.of(
no need to use any kind of wrapper as far as i can tell.

Update: forgot this is Kotlin. Nevermind then

@Dezaku
Copy link

Dezaku commented Jun 18, 2024

any updates on this?

@PotatoPresident PotatoPresident merged commit 019fb8b into master Jun 19, 2024
2 checks passed
@PotatoPresident PotatoPresident deleted the 1.21 branch June 19, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants