Bump 2.3.3

[robotpilot]

No description provided.

[gemini-code-assist]

Hello @robotpilot, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello team,

Gemini here, providing a summary of this pull request to help everyone get up to speed quickly.

This pull request, titled "Bump 2.3.3", primarily focuses on updating the version number of the turtlebot3_fake_node, turtlebot3_gazebo, and turtlebot3_simulations packages to 2.3.3. Alongside the version bumps in the package.xml files, the CHANGELOG.rst files for each package have been updated to include the new version entry and note a change related to deprecating ament_include_dependency usage in CMakeLists.txt, referencing a related pull request.

The CMakeLists.txt files in turtlebot3_fake_node and turtlebot3_gazebo have also been modified. The changes involve replacing the use of the ament_target_dependencies macro with the standard CMake command target_link_libraries, explicitly listing the required library targets. Additionally, the ament_export_dependencies calls have been reformatted to list dependencies within parentheses rather than separate calls.

Overall, this PR appears to be a standard version bump release incorporating a specific CMake dependency handling update.

Highlights

• CMake Dependency Handling Update: In turtlebot3_fake_node/CMakeLists.txt and turtlebot3_gazebo/CMakeLists.txt, the ament_target_dependencies macro has been replaced with the standard CMake target_link_libraries command, linking against specific library targets (e.g., ${geometry_msgs_TARGETS}, rclcpp::rclcpp).
• Changelog Updates: The CHANGELOG.rst files for the affected packages have been updated to include the 2.3.3 release entry, noting the CMake dependency change and crediting the contributor.
• CMake Formatting: The ament_export_dependencies calls in the CMakeLists.txt files have been reformatted to list dependencies within parentheses.

Changelog

Click here to see the changelog

• turtlebot3_fake_node/CHANGELOG.rst
  • Added entry for version 2.3.3 (2025-05-29).
  • Noted deprecation of ament_include_dependency usage in CMakeLists.txt, referencing PR Replace ament_target_dependencies with target_link_libraries #234.
  • Credited contributor ahcorde.
• turtlebot3_gazebo/CHANGELOG.rst
  • Added entry for version 2.3.3 (2025-05-29).
  • Noted deprecation of ament_include_dependency usage in CMakeLists.txt, referencing PR Replace ament_target_dependencies with target_link_libraries #234.
  • Credited contributor ahcorde.
• turtlebot3_simulations/CHANGELOG.rst
  • Added entry for version 2.3.3 (2025-05-29).
  • Noted deprecation of ament_include_dependency usage in CMakeLists.txt, referencing PR Replace ament_target_dependencies with target_link_libraries #234.
  • Credited contributor ahcorde.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Version number climbs,
CMake lists change their lines,
Code evolves again.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull Request Overview

This PR updates the TurtleBot3 packages to version 2.3.3, deprecating ament_include_dependency in CMakeLists and adding corresponding changelog entries.

• Bumps package versions from 2.3.2 to 2.3.3 in each package.xml
• Appends new 2.3.3 entries to CHANGELOG.rst for all packages
• Refactors CMakeLists.txt: replaces ament_target_dependencies with explicit target_link_libraries and switches to block-style ament_export_dependencies

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
turtlebot3_simulations/package.xml	Bump to version 2.3.3
turtlebot3_simulations/CHANGELOG.rst	Add 2.3.3 changelog entry
turtlebot3_gazebo/package.xml	Bump to version 2.3.3
turtlebot3_gazebo/CMakeLists.txt	Refactor dependency linking and export syntax
turtlebot3_gazebo/CHANGELOG.rst	Add 2.3.3 changelog entry
turtlebot3_fake_node/package.xml	Bump to version 2.3.3
turtlebot3_fake_node/CMakeLists.txt	Refactor dependency linking and export syntax
turtlebot3_fake_node/CHANGELOG.rst	Add 2.3.3 changelog entry

Comments suppressed due to low confidence (3)

turtlebot3_fake_node/CHANGELOG.rst:2

• The header references "turtlebot3_fake" but the directory and package name are "turtlebot3_fake_node"; update the header to match the actual package name.

Changelog for package turtlebot3_fake

turtlebot3_gazebo/CMakeLists.txt:45

• [nitpick] Mixing ${geometry_msgs_TARGETS} variables with direct CMake targets (rclcpp::rclcpp, tf2::tf2) is inconsistent; consider using ament_target_dependencies for clearer, unified dependency handling.

target_link_libraries(${EXEC_NAME}

turtlebot3_fake_node/CMakeLists.txt:37

• [nitpick] Dependency linking combines ${..._TARGETS} variables with direct targets; for consistency and maintainability, consider reverting to ament_target_dependencies or standardizing on imported targets.

target_link_libraries(${EXEC_NAME}

[gemini-code-assist]

Code Review

This pull request effectively bumps the version to 2.3.3 across the turtlebot3_fake_node, turtlebot3_gazebo, and turtlebot3_simulations packages. The accompanying changes to CMakeLists.txt files, which modernize dependency handling by replacing ament_target_dependencies with target_link_libraries and consolidating ament_export_dependencies, are well-executed and align with current best practices in ament_cmake.

The changelogs have been updated accordingly. The code quality is good, and the changes contribute to better maintainability.

Summary of Findings

• Version Update: All relevant package versions and changelogs have been consistently updated to 2.3.3.
• CMake Modernization: The CMakeLists.txt files for turtlebot3_fake_node and turtlebot3_gazebo have been successfully updated to use target_link_libraries with modern CMake targets (e.g., rclcpp::rclcpp, ${pkg_name_TARGETS}) instead of the older ament_target_dependencies macro. Additionally, multiple ament_export_dependencies calls have been consolidated into single, multi-argument calls, improving readability. These changes are beneficial and follow recommended practices.
• Changelog Content: Changelogs accurately reflect the version bump and the nature of the CMake changes. The reference to PR Replace ament_target_dependencies with target_link_libraries #234 (this PR) in the changelog entries is noted.

Merge Readiness

The pull request is well-prepared and the changes are beneficial. The version bump is consistent, and the CMake modernizations improve the build scripts. Based on this review, the code appears to be in good shape for merging. As always, ensure any CI checks pass and consider any further internal review processes before merging. I am not authorized to approve pull requests.