Skip to content

[rocminfo] Use idomatic approach to extending CMAKE_MODULE_PATH #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marbre opened this issue Mar 26, 2025 · 2 comments · Fixed by #512
Closed

[rocminfo] Use idomatic approach to extending CMAKE_MODULE_PATH #300

marbre opened this issue Mar 26, 2025 · 2 comments · Fixed by #512
Labels
patch Used to track patches

Comments

@marbre
Copy link
Member

marbre commented Mar 26, 2025

Summary

Extend CMAKE_MODULE_PATH via list(PREPEND.

Link to patch

https://github.com/ROCm/TheRock/blob/main/patches/amd-mainline/rocminfo/0001-Use-idomatic-approach-to-extending-CMAKE_MODULE_PATH.patch

Permalink to patch

https://github.com/ROCm/TheRock/blob/1af5e45b566e11924bb343018be93d870acdaf4a/patches/amd-mainline/rocminfo/0001-Use-idomatic-approach-to-extending-CMAKE_MODULE_PATH.patch
@marbre marbre added the patch Used to track patches label Mar 26, 2025
@jayhawk-commits
Copy link
Contributor

This landed upstream on amd-staging ROCm/rocminfo@8503ec3 but it is not in amd-mainline yet

@marbre marbre moved this from TODO to In Progress in TheRock Patches🪨🚀 Mar 31, 2025
@zichguan-amd
Copy link
Contributor

Landed in amd-mainline aec5d6fa53152668207d523ac481cc1ec9fb7298

@zichguan-amd zichguan-amd mentioned this issue May 1, 2025
Merged
@marbre marbre closed this as completed in e7bb685 May 2, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in TheRock Patches🪨🚀 May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
patch Used to track patches
Projects
TheRock Patches🪨🚀
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump rocminfo submodules 20250501 and track amd-staging zichguan-amd/TheRock
3 participants
@marbre @jayhawk-commits @zichguan-amd