Skip to content

[rockprofiler-sdk] Extend the hack to propagate HIP usage requirements a bit further #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marbre opened this issue Mar 26, 2025 · 0 comments
Labels
patch Used to track patches

Comments

@marbre
Copy link
Member

marbre commented Mar 26, 2025

Summary

  • Also fetches usage requirements from hip::amdhip64 -> rocprofiler-sdk-hip-nolink
  • Adds rocprofiler-sdk-hip-nolink as a dependency of two libraries that indirectly depend on hip headers via hip.h.
  • The above may not be completely as precise as it can be (it seems like there should be an intermediate library for this of some kind).
  • Also conditions the link of hsa-amd-aqlprofile64_library on whether the library was found, which however might not be correct.

Link to patch

https://github.com/ROCm/TheRock/blob/main/patches/amd-mainline/rocprofiler-sdk/0001-Extend-the-hack-to-propagate-HIP-usage-requirements-.patch

Permalink to patch

https://github.com/ROCm/TheRock/blob/1af5e45b566e11924bb343018be93d870acdaf4a/patches/amd-mainline/rocprofiler-sdk/0001-Extend-the-hack-to-propagate-HIP-usage-requirements-.patch

@marbre marbre added the patch Used to track patches label Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Used to track patches
Projects
Development

No branches or pull requests

1 participant