Skip to content

Invoke Pytorch Docker Image Verification by Pytorch Docker Image Publish #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 53 commits into
base: main
Choose a base branch
from

Conversation

erman-gurses
Copy link
Contributor

@erman-gurses erman-gurses commented Apr 8, 2025

The workflows, verify_docker_image.yml and publish_pytorch_dev_docker.yml, are needed to be connected since the published docker images should be verified. The current work plan as below:
Publish -> Verify ->Tag the image if verification passed

@erman-gurses
Copy link
Contributor Author

erman-gurses commented Apr 8, 2025

Workflow connection works: https://github.com/ROCm/TheRock/actions/runs/14322720619
On-success mode works: https://github.com/ROCm/TheRock/actions/runs/14349513136
Two fail case tested: https://github.com/ROCm/TheRock/actions/runs/14509534824
Tests with the new architecture: https://github.com/ROCm/TheRock/actions/runs/14531361731 (One pass and two fail case as expected)

@erman-gurses erman-gurses requested review from marbre and ScottTodd April 9, 2025 17:21
@erman-gurses erman-gurses marked this pull request as ready for review April 9, 2025 17:22
@erman-gurses erman-gurses force-pushed the users/erman-gurses/connect_image_publish_and_verify branch 8 times, most recently from ecf0a60 to 7b2c289 Compare April 10, 2025 07:25
@erman-gurses erman-gurses marked this pull request as draft April 10, 2025 15:51
@erman-gurses erman-gurses force-pushed the users/erman-gurses/connect_image_publish_and_verify branch 9 times, most recently from cca9b33 to 3eb1796 Compare April 10, 2025 22:08
@erman-gurses erman-gurses force-pushed the users/erman-gurses/connect_image_publish_and_verify branch 2 times, most recently from 2f18303 to 479025f Compare April 17, 2025 23:47
@erman-gurses erman-gurses force-pushed the users/erman-gurses/connect_image_publish_and_verify branch from 479025f to 6ef6f46 Compare April 17, 2025 23:56
@erman-gurses erman-gurses force-pushed the users/erman-gurses/connect_image_publish_and_verify branch 23 times, most recently from 108617f to 59d9790 Compare April 18, 2025 07:02
@erman-gurses erman-gurses force-pushed the users/erman-gurses/connect_image_publish_and_verify branch from 59d9790 to f74c75a Compare April 18, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: TODO
Development

Successfully merging this pull request may close these issues.

Invoke the current docker build matrix job followed by the docker image verification workflow.
3 participants