You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Subprojects install into the hardcoded C:/hipSDK path
Subprojects that depend on other subprojects fail to find expected files since they are searching the wrong locations:
[build] [hipFFT configure] CMake Error at D:/projects/TheRock/cmake/therock_subproject_dep_provider.cmake:51 (find_package):
[build] [hipFFT configure] Could not find a package configuration file provided by "rocfft" with any
[build] [hipFFT configure] of the following names:
[build] [hipFFT configure]
[build] [hipFFT configure] rocfftConfig.cmake
[build] [hipFFT configure] rocfft-config.cmake
In that case, C:\hipSDK\lib\cmake\rocfft\rocfft-config.cmake exists but TheRock\build\math-libs\rocFFT\dist\lib\cmake\rocfft\rocfft-config.cmake does not.
See #343. On Windows, these
projects have been force setting `CMAKE_INSTALL_PREFIX` to `C:/hipSDK`,
regardless of what any superproject or user requests. The canonical way
to set a default install prefix is to first check
`CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT`:
https://cmake.org/cmake/help/latest/variable/CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT.html
and then _not_ use `FORCE`. These are minimal changes to stop the
sub-projects from grossly misbehaving.
Summary
Per the guidance at https://cmake.org/cmake/help/latest/variable/CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT.html,
CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT
can be "used by project code to change the default without overriding a user-provided value".Without these patches:
Our setting here is ignored:
TheRock/cmake/therock_subproject.cmake
Line 641 in bc656e4
Subprojects install into the hardcoded
C:/hipSDK
pathSubprojects that depend on other subprojects fail to find expected files since they are searching the wrong locations:
In that case,
C:\hipSDK\lib\cmake\rocfft\rocfft-config.cmake
exists butTheRock\build\math-libs\rocFFT\dist\lib\cmake\rocfft\rocfft-config.cmake
does not.Link to patch
See #340
Sent to subprojects
No PRs sent yet
The text was updated successfully, but these errors were encountered: