Skip to content

Invoke the current docker build matrix job followed by the docker image verification workflow. #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
erman-gurses opened this issue Mar 27, 2025 · 6 comments · May be fixed by #361
Open

Invoke the current docker build matrix job followed by the docker image verification workflow. #309

erman-gurses opened this issue Mar 27, 2025 · 6 comments · May be fixed by #361
Assignees
@erman-gurses
Labels
CICD Related to CI/CD Infra enhancement New feature or request

Comments

@erman-gurses
Copy link
Contributor

erman-gurses commented Mar 27, 2025 •
edited
Loading

The workflows, verify_docker_image.yml and publish_pytorch_dev_docker.yml, are needed to be connected since the published docker images should be verified. The current work plan as below:
Publish -> Verify -> Tag the Image If Verification Passed
@erman-gurses erman-gurses converted this from a draft issue Mar 27, 2025
@erman-gurses erman-gurses self-assigned this Mar 27, 2025
@erman-gurses erman-gurses added enhancement New feature or request CICD Related to CI/CD Infra labels Mar 27, 2025
@erman-gurses erman-gurses moved this from TODO to In Progress in TheRock CI/CD 🪨🚀 Apr 7, 2025
@erman-gurses erman-gurses linked a pull request Apr 8, 2025 that will close this issue
Invoke Pytorch Docker Image Verification by Pytorch Docker Image Publish #361
Open
@amd-chrissosa
Copy link
Contributor

@erman-gurses is this complete?

@erman-gurses
Copy link
Contributor Author

erman-gurses commented Apr 17, 2025 •
edited
Loading

@erman-gurses is this complete?

@amd-chrissosa, Not yet - still do some testing - I am about to finish it. I might need to change some architectures as well as a future work. cc @marbre

@erman-gurses
Copy link
Contributor Author

Image

@erman-gurses
Copy link
Contributor Author

Image

@erman-gurses
Copy link
Contributor Author

erman-gurses commented Apr 18, 2025 •
edited
Loading

I changed the architecture and now we use benc-uk/workflow-dispatch@e2e5e9a103e331dad343f381a29e654aea3cf8fc to trigger verification workflow. The verification is passed for gfx942 as expected and please see the logs for that logs. On the other hand, the verifications are failed for gfx1100 and gfx1201 as expected since there is no healthy runners for those targets. The full logs can be seen in here
CC: @marbre @ScottTodd @geomin12

@erman-gurses
Copy link
Contributor Author

erman-gurses commented Apr 18, 2025 •
edited
Loading

Also added a proof of that tagging mechanism is working with the correct version number 64.0rc20250418
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erman-gurses erman-gurses

Labels
CICD Related to CI/CD Infra enhancement New feature or request
Projects
TheRock CI/CD 🪨🚀
Status: In Progress
TheRock Triage
Status: TODO
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Invoke Pytorch Docker Image Verification by Pytorch Docker Image Publish ROCm/TheRock
2 participants
@erman-gurses @amd-chrissosa