Skip to content

[ROCR-Runtime] Search for libnuma with find_package before find_library #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marbre opened this issue Mar 25, 2025 · 4 comments · Fixed by #391
Closed

[ROCR-Runtime] Search for libnuma with find_package before find_library #282

marbre opened this issue Mar 25, 2025 · 4 comments · Fixed by #391
Labels
patch Used to track patches

Comments

@marbre
Copy link
Member

marbre commented Mar 25, 2025

Summary

To avoid a false dependence on a system library when not desired, find_package() is used before find_library().

Link to patch

https://github.com/ROCm/TheRock/blob/main/patches/amd-mainline/ROCR-Runtime/0001-Search-for-libnuma-with-find_package-before-find_lib.patch

Permalink to patch

https://github.com/ROCm/TheRock/blob/6e1bd9b82a581487712f95ef86c0ba27c77faec9/patches/amd-mainline/ROCR-Runtime/0001-Search-for-libnuma-with-find_package-before-find_lib.patch
@marbre marbre added the patch Used to track patches label Mar 25, 2025
@amd-jmacaran
Copy link
Contributor

This patch landed upstream on amd-staging branch: ROCm/ROCR-Runtime@c36ccaa

@amd-jmacaran
Copy link
Contributor

Looks like it's also in amd-mainline as well.

@github-project-automation github-project-automation bot moved this from TODO to Done in TheRock Patches🪨🚀 Mar 31, 2025
@amd-jmacaran amd-jmacaran reopened this Mar 31, 2025
@amd-jmacaran amd-jmacaran moved this from Done to In Progress in TheRock Patches🪨🚀 Mar 31, 2025
@marbre marbre mentioned this issue Apr 1, 2025
Merged
@marbre marbre moved this from In Progress to Done in TheRock Patches🪨🚀 Apr 1, 2025
@marbre marbre closed this as completed by moving to Done in TheRock Patches🪨🚀 Apr 1, 2025
@marbre
Copy link
Member Author

marbre commented Apr 1, 2025

Closed with the submodule bump #317.

@marbre
Copy link
Member Author

marbre commented Apr 8, 2025

Re-opening as the patch is not yet in amd-mainline even though is has landed to amd-staging.

@marbre marbre reopened this Apr 8, 2025
@marbre marbre moved this from Done to In Progress in TheRock Patches🪨🚀 Apr 9, 2025
marbre added a commit that referenced this issue Apr 10, 2025
@marbre
Switch from amd-master to amd-mainline
50587a6 
Closes #282
@marbre marbre mentioned this issue Apr 10, 2025
Merged
@marbre marbre closed this as completed in 377abe2 Apr 13, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in TheRock Patches🪨🚀 Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
patch Used to track patches
Projects
TheRock Patches🪨🚀
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch from amd-master to amd-mainline ROCm/TheRock
2 participants
@marbre @amd-jmacaran