hipBLASLt: bump submodule to include gfx1151 support #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing
pass on the ASUS Z13 with this patch |
marbre
reviewed
Apr 7, 2025
| + try: | ||
| + globalParameters["ROCmSMIPath"] = locateExe(globalParameters["ROCmBinPath"], "rocm-smi") | ||
| + except OSError: | ||
| + pass |
There was a problem hiding this comment.
@marbre , since rocm-smi would not work under the WSL for some time(?), should we ask hipBLASLt to integrate this change?
There was a problem hiding this comment.
We'll address this in a meeting later today.
scottt
force-pushed
the
gfx1151-for-merge
branch
2 times, most recently
from
689bc83 to
df4dc6c
Compare
|
I amended the hipBLASLt/0008-tensilelite-make-roc-smi-binary-optional-during-buil.patch to only attempt to use |
stellaraccident
force-pushed
the
gfx1151-for-merge
branch
from
df4dc6c to
720b2bc
Compare
Bump hipBLASLt submodule to include a revision that has gfx1151 support and can build rocBLAS. Adapt TheRock hipBLASLt patches to match.
stellaraccident
force-pushed
the
gfx1151-for-merge
branch
from
720b2bc to
fe89c6c
Compare
|
I triaged this a bit more and reworked a little bit, dropping one patch in the process. The new patch looks fine to me to send to the upstream project. |
|
Thanks @stellaraccident! I'll base the next PR in the gfx1151 work on this and also submit the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump hipBLASLt submodule to include a revision that has gfx1151 support and can build rocBLAS.
Adapt TheRock hipBLASLt patches to match.