Skip to content

Patch win32 install prefixes in several BLAS libraries. #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025

Conversation

ScottTodd
Copy link
Member

See #343. On Windows, these projects have been force setting CMAKE_INSTALL_PREFIX to C:/hipSDK, regardless of what any superproject or user requests. The canonical way to set a default install prefix is to first check CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT: https://cmake.org/cmake/help/latest/variable/CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT.html and then not use FORCE. These are minimal changes to stop the sub-projects from grossly misbehaving.

@ScottTodd
Copy link
Member Author

Windows CI failed with

 [amd-llvm] C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.43.34808\include\xutility(2074): fatal error C1060: compiler is out of heap space

https://github.com/ROCm/TheRock/actions/runs/14345447997/job/40214198082?pr=378#step:11:2436

I'm going to assume that's a runner issue that will go away on a retry or after clearing some space on the CI runner somehow. Can retry the job once the other workflows finish.

@stellaraccident
Copy link
Collaborator

Do you think it was out of system memory or something silly like using a 32bit msvc?

@ScottTodd
Copy link
Member Author

Failed again with the more direct No space left on device on a retry:

[amd-llvm] C:\home\runner\_work\TheRock\TheRock\compiler\amd-llvm\llvm\utils\TableGen\Common\CodeGenInstAlias.cpp : fatal error C1085: Cannot write compiler generated file: 'C:\mnt\azure\b\023850\compiler\amd-llvm\build\utils\TableGen\Common\CMakeFiles\obj.LLVMTableGenCommon.dir\CodeGenInstAlias.cpp.obj': No space left on device

https://github.com/ROCm/TheRock/actions/runs/14345447997/job/40220623635?pr=378#step:11:1379

I suspect the shared network drive just filled up somehow. New runners with appropriately sized ephemeral disks will fix that issue, or we can have someone go into the cloud project / shared drive settings somewhere and free up space.

@ScottTodd ScottTodd merged commit 817950a into main Apr 9, 2025
10 of 11 checks passed
@ScottTodd ScottTodd deleted the users/scotttodd/win32-blas-install-prefix branch April 9, 2025 03:06
@github-project-automation github-project-automation bot moved this from TODO to Done in TheRock Triage Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants