Skip to content

Bump submodules 20250410 #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025
Merged

Bump submodules 20250410 #390

merged 2 commits into from
Apr 11, 2025

Conversation

marbre
Copy link
Member

@marbre marbre commented Apr 10, 2025

  • Bumps all submodules, expect hipBLASLt, to remote heads:
    hipBLASLt points to a commit at develop whereas the module defaults to mainline.
  • Manually keps the Tensile pin.

* Bumps all submodules, expect hipBLASLt, to remote heads:
  hipBLASLt points to a commit at develop whereas the module defaults to
  mainline.
* Manually keps the Tensile pin.
@marbre marbre marked this pull request as ready for review April 10, 2025 15:31
@marbre
Copy link
Member Author

marbre commented Apr 10, 2025

The following tests fail

  • rocTHRUST
    • 17 - copy.hip (Failed)
  • rocPRIM
    • 51 - rocprim.lookback_reproducibility (Failed)
    • 75 - rocprim.linking (Failed)

@marbre
Copy link
Member Author

marbre commented Apr 11, 2025

Thanks for adding the filtering @geomin12. In difference to an expected failure, tests wont run at all whit this. An alternative might be to set WILL_FAIL to the test targets at CMake level. Looking into it this unfortunately a little painful due to the way test targets are added. Another option could be to use one of the GoogleTest macros (ASSERT_NO_FATAL_FAILURE, EXPECT_NO_FATAL_FAILURE). Both options would require to patch the projects themselves, which might not be too bad as there is at least hope that those patches can be dropped sooner or later. @stellaraccident any preference?

@geomin12
Copy link
Contributor

Thanks for adding the filtering @geomin12. In difference to an expected failure, tests wont run at all whit this. An alternative might be to set WILL_FAIL to the test targets at CMake level. Looking into it this unfortunately a little painful due to the way test targets are added. Another option could be to use one of the GoogleTest macros (ASSERT_NO_FATAL_FAILURE, EXPECT_NO_FATAL_FAILURE). Both options would require to patch the projects themselves, which might not be too bad as there is at least hope that those patches can be dropped sooner or later. @stellaraccident any preference?

ah i see! would we prefer the "xfail" or explicitly removing them from the test runs? i can adjust to whatever is preferred

@marbre
Copy link
Member Author

marbre commented Apr 11, 2025

Thanks for adding the filtering @geomin12. In difference to an expected failure, tests wont run at all whit this. An alternative might be to set WILL_FAIL to the test targets at CMake level. Looking into it this unfortunately a little painful due to the way test targets are added. Another option could be to use one of the GoogleTest macros (ASSERT_NO_FATAL_FAILURE, EXPECT_NO_FATAL_FAILURE). Both options would require to patch the projects themselves, which might not be too bad as there is at least hope that those patches can be dropped sooner or later. @stellaraccident any preference?

ah i see! would we prefer the "xfail" or explicitly removing them from the test runs? i can adjust to whatever is preferred

As discussed in today's meeting we probably merge as is and fill an issue for now but definitely need to follow up if more tests start to fail.

@marbre
Copy link
Member Author

marbre commented Apr 11, 2025

Filled #400 and #401.

@marbre marbre merged commit 19b5e28 into main Apr 11, 2025
11 checks passed
@marbre marbre deleted the users/marbre/bump-20250410 branch April 11, 2025 17:46
@github-project-automation github-project-automation bot moved this from TODO to Done in TheRock Triage Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants