Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More pin field fixes #149

Merged
merged 2 commits into from
Jan 28, 2024
Merged

More pin field fixes #149

merged 2 commits into from
Jan 28, 2024

Conversation

Rahix
Copy link
Owner

@Rahix Rahix commented Jan 28, 2024

Rahix added 2 commits January 28, 2024 18:19
@Rahix
attiny167: Add missing pin fields
9f3fe2b 
See commit 789f288 ("attiny2313{,a}: Add missing pin fields") for
details.
@Rahix
attiny84: Add missing pin fields
79788d8 
See commit 789f288 ("attiny2313{,a}: Add missing pin fields") for
details.
@Rahix
Copy link
Owner Author

Rahix commented Jan 28, 2024

ATtiny167

diff --color -Nur svd-orig/attiny167.svd.patched svd/attiny167.svd.patched
--- svd-orig/attiny167.svd.patched	2024-01-28 18:18:08.076484565 +0100
+++ svd/attiny167.svd.patched	2024-01-28 18:18:12.863209047 +0100
@@ -2100,7 +2100,15 @@
               <maximum>255</maximum>
             </range>
           </writeConstraint>
-        </register>
+        <fields><field><name>PA0</name><description>Pin A0</description><bitRange>[0:0]</bitRange><access>read-write</access></field>
+            <field><name>PA1</name><description>Pin A1</description><bitRange>[1:1]</bitRange><access>read-write</access></field>
+            <field><name>PA2</name><description>Pin A2</description><bitRange>[2:2]</bitRange><access>read-write</access></field>
+            <field><name>PA3</name><description>Pin A3</description><bitRange>[3:3]</bitRange><access>read-write</access></field>
+            <field><name>PA4</name><description>Pin A4</description><bitRange>[4:4]</bitRange><access>read-write</access></field>
+            <field><name>PA5</name><description>Pin A5</description><bitRange>[5:5]</bitRange><access>read-write</access></field>
+            <field><name>PA6</name><description>Pin A6</description><bitRange>[6:6]</bitRange><access>read-write</access></field>
+            <field><name>PA7</name><description>Pin A7</description><bitRange>[7:7]</bitRange><access>read-write</access></field>
+            </fields></register>
         <register>
           <name>PINA</name>
           <description>Port A Input Pins</description>
@@ -2113,7 +2121,15 @@
               <maximum>255</maximum>
             </range>
           </writeConstraint>
-        </register>
+        <fields><field><name>PA0</name><description>Pin A0</description><bitRange>[0:0]</bitRange><access>read-write</access></field>
+            <field><name>PA1</name><description>Pin A1</description><bitRange>[1:1]</bitRange><access>read-write</access></field>
+            <field><name>PA2</name><description>Pin A2</description><bitRange>[2:2]</bitRange><access>read-write</access></field>
+            <field><name>PA3</name><description>Pin A3</description><bitRange>[3:3]</bitRange><access>read-write</access></field>
+            <field><name>PA4</name><description>Pin A4</description><bitRange>[4:4]</bitRange><access>read-write</access></field>
+            <field><name>PA5</name><description>Pin A5</description><bitRange>[5:5]</bitRange><access>read-write</access></field>
+            <field><name>PA6</name><description>Pin A6</description><bitRange>[6:6]</bitRange><access>read-write</access></field>
+            <field><name>PA7</name><description>Pin A7</description><bitRange>[7:7]</bitRange><access>read-write</access></field>
+            </fields></register>
         <register>
           <name>PORTA</name>
           <description>Port A Data Register</description>
@@ -2126,7 +2142,15 @@
               <maximum>255</maximum>
             </range>
           </writeConstraint>
-        </register>
+        <fields><field><name>PA0</name><description>Pin A0</description><bitRange>[0:0]</bitRange><access>read-write</access></field>
+            <field><name>PA1</name><description>Pin A1</description><bitRange>[1:1]</bitRange><access>read-write</access></field>
+            <field><name>PA2</name><description>Pin A2</description><bitRange>[2:2]</bitRange><access>read-write</access></field>
+            <field><name>PA3</name><description>Pin A3</description><bitRange>[3:3]</bitRange><access>read-write</access></field>
+            <field><name>PA4</name><description>Pin A4</description><bitRange>[4:4]</bitRange><access>read-write</access></field>
+            <field><name>PA5</name><description>Pin A5</description><bitRange>[5:5]</bitRange><access>read-write</access></field>
+            <field><name>PA6</name><description>Pin A6</description><bitRange>[6:6]</bitRange><access>read-write</access></field>
+            <field><name>PA7</name><description>Pin A7</description><bitRange>[7:7]</bitRange><access>read-write</access></field>
+            </fields></register>
       </registers>
     </peripheral>
     <peripheral>
@@ -2151,7 +2175,15 @@
               <maximum>255</maximum>
             </range>
           </writeConstraint>
-        </register>
+        <fields><field><name>PB0</name><description>Pin B0</description><bitRange>[0:0]</bitRange><access>read-write</access></field>
+            <field><name>PB1</name><description>Pin B1</description><bitRange>[1:1]</bitRange><access>read-write</access></field>
+            <field><name>PB2</name><description>Pin B2</description><bitRange>[2:2]</bitRange><access>read-write</access></field>
+            <field><name>PB3</name><description>Pin B3</description><bitRange>[3:3]</bitRange><access>read-write</access></field>
+            <field><name>PB4</name><description>Pin B4</description><bitRange>[4:4]</bitRange><access>read-write</access></field>
+            <field><name>PB5</name><description>Pin B5</description><bitRange>[5:5]</bitRange><access>read-write</access></field>
+            <field><name>PB6</name><description>Pin B6</description><bitRange>[6:6]</bitRange><access>read-write</access></field>
+            <field><name>PB7</name><description>Pin B7</description><bitRange>[7:7]</bitRange><access>read-write</access></field>
+            </fields></register>
         <register>
           <name>PINB</name>
           <description>Port B Input Pins</description>
@@ -2164,7 +2196,15 @@
               <maximum>255</maximum>
             </range>
           </writeConstraint>
-        </register>
+        <fields><field><name>PB0</name><description>Pin B0</description><bitRange>[0:0]</bitRange><access>read-write</access></field>
+            <field><name>PB1</name><description>Pin B1</description><bitRange>[1:1]</bitRange><access>read-write</access></field>
+            <field><name>PB2</name><description>Pin B2</description><bitRange>[2:2]</bitRange><access>read-write</access></field>
+            <field><name>PB3</name><description>Pin B3</description><bitRange>[3:3]</bitRange><access>read-write</access></field>
+            <field><name>PB4</name><description>Pin B4</description><bitRange>[4:4]</bitRange><access>read-write</access></field>
+            <field><name>PB5</name><description>Pin B5</description><bitRange>[5:5]</bitRange><access>read-write</access></field>
+            <field><name>PB6</name><description>Pin B6</description><bitRange>[6:6]</bitRange><access>read-write</access></field>
+            <field><name>PB7</name><description>Pin B7</description><bitRange>[7:7]</bitRange><access>read-write</access></field>
+            </fields></register>
         <register>
           <name>PORTB</name>
           <description>Port B Data Register</description>
@@ -2177,7 +2217,15 @@
               <maximum>255</maximum>
             </range>
           </writeConstraint>
-        </register>
+        <fields><field><name>PB0</name><description>Pin B0</description><bitRange>[0:0]</bitRange><access>read-write</access></field>
+            <field><name>PB1</name><description>Pin B1</description><bitRange>[1:1]</bitRange><access>read-write</access></field>
+            <field><name>PB2</name><description>Pin B2</description><bitRange>[2:2]</bitRange><access>read-write</access></field>
+            <field><name>PB3</name><description>Pin B3</description><bitRange>[3:3]</bitRange><access>read-write</access></field>
+            <field><name>PB4</name><description>Pin B4</description><bitRange>[4:4]</bitRange><access>read-write</access></field>
+            <field><name>PB5</name><description>Pin B5</description><bitRange>[5:5]</bitRange><access>read-write</access></field>
+            <field><name>PB6</name><description>Pin B6</description><bitRange>[6:6]</bitRange><access>read-write</access></field>
+            <field><name>PB7</name><description>Pin B7</description><bitRange>[7:7]</bitRange><access>read-write</access></field>
+            </fields></register>
       </registers>
     </peripheral>

ATtiny84

diff --color -Nur svd-orig/attiny84.svd.patched svd/attiny84.svd.patched
--- svd-orig/attiny84.svd.patched	2024-01-28 18:22:28.672939564 +0100
+++ svd/attiny84.svd.patched	2024-01-28 18:22:36.656367830 +0100
@@ -1257,7 +1257,15 @@
               <maximum>255</maximum>
             </range>
           </writeConstraint>
-        </register>
+        <fields><field><name>PA0</name><description>Pin A0</description><bitRange>[0:0]</bitRange><access>read-write</access></field>
+            <field><name>PA1</name><description>Pin A1</description><bitRange>[1:1]</bitRange><access>read-write</access></field>
+            <field><name>PA2</name><description>Pin A2</description><bitRange>[2:2]</bitRange><access>read-write</access></field>
+            <field><name>PA3</name><description>Pin A3</description><bitRange>[3:3]</bitRange><access>read-write</access></field>
+            <field><name>PA4</name><description>Pin A4</description><bitRange>[4:4]</bitRange><access>read-write</access></field>
+            <field><name>PA5</name><description>Pin A5</description><bitRange>[5:5]</bitRange><access>read-write</access></field>
+            <field><name>PA6</name><description>Pin A6</description><bitRange>[6:6]</bitRange><access>read-write</access></field>
+            <field><name>PA7</name><description>Pin A7</description><bitRange>[7:7]</bitRange><access>read-write</access></field>
+            </fields></register>
         <register>
           <name>PINA</name>
           <description>Port A Input Pins</description>
@@ -1270,7 +1278,15 @@
               <maximum>255</maximum>
             </range>
           </writeConstraint>
-        </register>
+        <fields><field><name>PA0</name><description>Pin A0</description><bitRange>[0:0]</bitRange><access>read-write</access></field>
+            <field><name>PA1</name><description>Pin A1</description><bitRange>[1:1]</bitRange><access>read-write</access></field>
+            <field><name>PA2</name><description>Pin A2</description><bitRange>[2:2]</bitRange><access>read-write</access></field>
+            <field><name>PA3</name><description>Pin A3</description><bitRange>[3:3]</bitRange><access>read-write</access></field>
+            <field><name>PA4</name><description>Pin A4</description><bitRange>[4:4]</bitRange><access>read-write</access></field>
+            <field><name>PA5</name><description>Pin A5</description><bitRange>[5:5]</bitRange><access>read-write</access></field>
+            <field><name>PA6</name><description>Pin A6</description><bitRange>[6:6]</bitRange><access>read-write</access></field>
+            <field><name>PA7</name><description>Pin A7</description><bitRange>[7:7]</bitRange><access>read-write</access></field>
+            </fields></register>
         <register>
           <name>PORTA</name>
           <description>Port A Data Register</description>
@@ -1283,7 +1299,15 @@
               <maximum>255</maximum>
             </range>
           </writeConstraint>
-        </register>
+        <fields><field><name>PA0</name><description>Pin A0</description><bitRange>[0:0]</bitRange><access>read-write</access></field>
+            <field><name>PA1</name><description>Pin A1</description><bitRange>[1:1]</bitRange><access>read-write</access></field>
+            <field><name>PA2</name><description>Pin A2</description><bitRange>[2:2]</bitRange><access>read-write</access></field>
+            <field><name>PA3</name><description>Pin A3</description><bitRange>[3:3]</bitRange><access>read-write</access></field>
+            <field><name>PA4</name><description>Pin A4</description><bitRange>[4:4]</bitRange><access>read-write</access></field>
+            <field><name>PA5</name><description>Pin A5</description><bitRange>[5:5]</bitRange><access>read-write</access></field>
+            <field><name>PA6</name><description>Pin A6</description><bitRange>[6:6]</bitRange><access>read-write</access></field>
+            <field><name>PA7</name><description>Pin A7</description><bitRange>[7:7]</bitRange><access>read-write</access></field>
+            </fields></register>
       </registers>
     </peripheral>
     <peripheral>
@@ -1308,7 +1332,11 @@
               <maximum>255</maximum>
             </range>
           </writeConstraint>
-        </register>
+        <fields><field><name>PB0</name><description>Pin B0</description><bitRange>[0:0]</bitRange><access>read-write</access></field>
+            <field><name>PB1</name><description>Pin B1</description><bitRange>[1:1]</bitRange><access>read-write</access></field>
+            <field><name>PB2</name><description>Pin B2</description><bitRange>[2:2]</bitRange><access>read-write</access></field>
+            <field><name>PB3</name><description>Pin B3</description><bitRange>[3:3]</bitRange><access>read-write</access></field>
+            </fields></register>
         <register>
           <name>PINB</name>
           <description>Input Pins, Port B</description>
@@ -1321,7 +1349,11 @@
               <maximum>255</maximum>
             </range>
           </writeConstraint>
-        </register>
+        <fields><field><name>PB0</name><description>Pin B0</description><bitRange>[0:0]</bitRange><access>read-write</access></field>
+            <field><name>PB1</name><description>Pin B1</description><bitRange>[1:1]</bitRange><access>read-write</access></field>
+            <field><name>PB2</name><description>Pin B2</description><bitRange>[2:2]</bitRange><access>read-write</access></field>
+            <field><name>PB3</name><description>Pin B3</description><bitRange>[3:3]</bitRange><access>read-write</access></field>
+            </fields></register>
         <register>
           <name>PORTB</name>
           <description>Data Register, Port B</description>
@@ -1334,7 +1366,11 @@
               <maximum>255</maximum>
             </range>
           </writeConstraint>
-        </register>
+        <fields><field><name>PB0</name><description>Pin B0</description><bitRange>[0:0]</bitRange><access>read-write</access></field>
+            <field><name>PB1</name><description>Pin B1</description><bitRange>[1:1]</bitRange><access>read-write</access></field>
+            <field><name>PB2</name><description>Pin B2</description><bitRange>[2:2]</bitRange><access>read-write</access></field>
+            <field><name>PB3</name><description>Pin B3</description><bitRange>[3:3]</bitRange><access>read-write</access></field>
+            </fields></register>
       </registers>
     </peripheral>
     <peripheral>

@Rahix Rahix mentioned this pull request Jan 28, 2024
Merged
@Rahix Rahix merged commit bacd737 into main Jan 28, 2024
2 checks passed
@Rahix Rahix deleted the more-pin-field-fixes branch January 28, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Rahix