Skip to content

Current forced small row height in Flat Data Grid obscures underscores and descender parts of text #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
entact-vhorvath opened this issue Dec 9, 2023 · 2 comments
Labels
enhancement Feature enhancement

Comments

@entact-vhorvath
Copy link

The current line height obscures important textual information (underscores). This is vital for applications where data contains underscores, e.g. XML based data formats.

Using your examples one can see that the part of the text falling under the baseline is now invisible, see note field, e.g. _untitled_19:

image

Please consider adding:

.github-octo-flat-ui {
  line-height: 1.0 !important;
}

Result:
image

@RandomFractals
Copy link
Owner

RandomFractals commented Dec 10, 2023

@entact-vhorvath yes, I did not notice this when I reduced row height to display more rows. Will reduce the default font size in the next update to patch this.

@entact-vhorvath
Copy link
Author

Perhaps it would be useful to give users the option to change this setting via the VSCode settings interface. Could be a few profiles that would allow users to pick from font sizes and packing of the rows (line heights), or a direct mapping between CSS values, whatever better fits the purpose. This extension might be combined with others and it is hard to inject a CSS rule from the outside, config seems to be a better way where you also can sanitize input.

@RandomFractals RandomFractals added the enhancement Feature enhancement label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature enhancement
Projects
None yet
Development

No branches or pull requests

2 participants