Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sour Sprites Update #1017

Merged
merged 14 commits into from
Feb 21, 2025
Merged

Sour Sprites Update #1017

merged 14 commits into from
Feb 21, 2025

Conversation

SoupPotato
Copy link
Collaborator

Up-to-date sprites for Polished. Please convert each sprite both front and back to grayscale as needed

Rangi42
Rangi42 reviewed Feb 3, 2025
View reviewed changes
@Rangi42 Rangi42 removed their assignment Feb 3, 2025
Rangi42
Rangi42 previously requested changes Feb 3, 2025
View reviewed changes
Copy link
Owner

@Rangi42 Rangi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom shinies should not change.

@vulcandth
Copy link
Collaborator

vulcandth commented Feb 3, 2025 •
edited
Loading

I think this is a duplicate of #990; where I cleaned up the superfluous changes... but if we wat to work off of this one.. that works too.

@vulcandth vulcandth added this to the 3.2.0 milestone Feb 3, 2025
@vulcandth vulcandth added enhancement cosmetic patch-version These can be applied anytime as a "bugfix" release labels Feb 3, 2025
@SoupPotato
Copy link
Collaborator Author

Palettes have been corrected

@SoupPotato SoupPotato assigned SoupPotato and Rangi42 and unassigned SoupPotato Feb 16, 2025
Rangi42
Rangi42 reviewed Feb 21, 2025
View reviewed changes
Rangi42
Rangi42 requested changes Feb 21, 2025
View reviewed changes
Copy link
Owner

@Rangi42 Rangi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for so much attention to detail here! There are a couple of poses where I happen to prefer the originals, but overall, this vastly cleans up the sprites, from minor details like moving/resizing a mouth, to complete redraws. 👍

Rangi42
Rangi42 reviewed Feb 21, 2025
View reviewed changes
gfx/pokemon/houndoom/front.png
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That filesize looks like it needs grayscale.py run

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'll run it on png files in general)

@SoupPotato SoupPotato requested a review from Rangi42 February 21, 2025 17:52
@Rangi42 Rangi42 merged commit 74562be into master Feb 21, 2025
1 check passed
@Rangi42 Rangi42 deleted the SourSprites-9bit branch February 21, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rangi42 Rangi42 Rangi42 approved these changes

@vulcandth vulcandth vulcandth approved these changes

Assignees

@Rangi42 Rangi42

Labels
cosmetic enhancement patch-version These can be applied anytime as a "bugfix" release
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SoupPotato @vulcandth @Rangi42