fix: Group mount and install options into an argument group
#364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make using --mount option in 'patch' command require the inclusion of -i/--install option. - as it stands, if -i is not provided, then --mount flag is really not toggling the installation and user is left oblivious whether the patched apk is being installed or not
oSumAtrIX
requested changes
Apr 20, 2025
oSumAtrIX
changed the title
mount and install arguments into one argument group
oSumAtrIX
changed the title
mount and install arguments into one argument group mount and install arguments into an argument group
oSumAtrIX
reviewed
Apr 20, 2025
oSumAtrIX
reviewed
Apr 20, 2025
oSumAtrIX
changed the title
mount and install arguments into an argument group mount and install options into an argument group
oSumAtrIX
approved these changes
Apr 20, 2025
|
Thank you for contributing to ReVanced. Join us on Discord to receive a role for your contribution. |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 20, 2025
## [5.0.2-dev.1](v5.0.1...v5.0.2-dev.1) (2025-04-20) ### Bug Fixes * Group `mount` and `install` options into an argument group ([#364](#364)) ([0c53a2d](0c53a2d))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--mountoption in 'patch' command require the inclusion of-i/--installoption.-iis not provided, then--mountflag is really not toggling the installation and user is left oblivious whether the patched apk is being installed or not