Change keypath BindingTarget.init
to solve source breaking change in SE-0481
#890
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #889
SE-0481 would break the current version of the
BindingTarget.init
that takes a keypath. Changing the keypath type fromWritableKeyPath
toReferenceWritableKeyPath
fixes this, and is probably what the type should always have been, sinceObject
will always be a reference type.Despite the signature of the initalizer changing, this is unlikely to break existing code using it, as the keypath is almost always passed using keypath notation (eg :
\.property
) and not using an explicit keypath type.Checklist