Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Footer/Mobile Compatabiltiy #10

Open
ReefLakin opened this issue Apr 11, 2021 · 6 comments
Open

Address Footer/Mobile Compatabiltiy #10

ReefLakin opened this issue Apr 11, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ReefLakin
Copy link
Owner

The footer doesn't look that great on mobile.

To Do:

Space it out so it can breathe.

@ReefLakin ReefLakin added enhancement New feature or request good first issue Good for newcomers labels Apr 11, 2021
@AtharvaParkale
Copy link

Hello @ReefLakin ,
I would like to work on this issue.

@ReefLakin
Copy link
Owner Author

Hi, Atharva. Feel free to experiment if you do want to work on it. If you view the site on mobile, the footer just looks a little clunky for my liking. I was going to make some small changes to it.

This is the current code for that piece:

<div class="container-fluid bg-light">
    <footer style="text-align: center; padding-top: 1%">
        <div class="row">
            <p>&copy Reef Lakin 2021 | Based upon “ CATAN,” a creation and design of Klaus Teuber and property of CATAN GmbH.</p>
        </div>
    </footer>
</div>

Super basic. Don't hesitate to try and make it look or read a little better.

Suggestions

  • Add more spacing.
  • Separate the code block into its own php file so it can be easily added to each page.
  • Use Bootstrap rows and columns to achieve an effective and responsive look. Here's more information if you need it: https://getbootstrap.com/docs/5.0/layout/grid/

@AtharvaParkale
Copy link

Can I get the link to the website I am working on?

@AtharvaParkale
Copy link

Can I get the link to the website I am working on?

Never mind got it......

@AtharvaParkale
Copy link

I am so sorry for the delay.
There was an emergency at my house so I couldn't complete your issue, I am working on it now.

@ReefLakin
Copy link
Owner Author

It's fine. Don't stress about it. Addressing this isn't high priority, so you can take your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants