don't strip keyword argument names with --strip-metadata (#58412) #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrobinson251
approved these changes
May 19, 2025
There was a problem hiding this comment.
Please can you update the description to say this is an manual backport Please can you update the description to say this is an manual backport? Maybe link to the slack thread too https://relationalai.slack.com/archives/C01BC96H69W/p1747340708025719?thread_ts=1746720003.439789&cid=C01BC96H69W
Are we waiting on upstream to merge first?
|
Updated the description.
No, this has been okayed as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Manually backported: the stripping code has been refactored upstream. Discussion on Slack.
These are used by
hasmethod, and in any case including keyword argument symbols is unavoidable so there is no cost to keeping these.Checklist
Requirements for merging:
port-to-*labels that don't apply.