ref: use org secret and bump base images and toolkits #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2025
satra
changed the title
…es. Removed curl and localedef in dependencies. Fix #653
* origin/master: pre-commit hooks auto-update (#658)
|
@iishiishii - this is the closest i have gotten to updating various components to take care of aging issues in tests. unfortunately, there are two tests that are still failing that i could not replicate in some hacked setups. i'll see if i can replicate a cleaner test environment. in the meantime, feel free to review if you have some time. |
|
@iishiishii - i think i fixed the two remaining bugs. will wait for CI to finish running. |
|
Fabulous, it works! Thank you for fixing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use the organization token rather than the project one.
closes #590 #653 #657 #654