-
Notifications
You must be signed in to change notification settings - Fork 9
[ENH] add code and test to help create schemas #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add allow in AddProperties
use new response option class rm old response option class
666e6eb
to
7fd2450
Compare
Things are starting to look better. There is still potential for refactoring but I may wait a bit before doing this. Want to test it on COBIDAS first and add some doc with sphinx to make sure whoever revisit this will not be thoroughly lost. |
clean_up(item_dir, item) | ||
|
||
|
||
def test_item1(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the creation of some files can still be quite involved if they are complex: I still would like to make the API more intuitive but I am not sure how much more I can do for now.
Note that not all parts of the schema have been covered yet. FYI: I tend to start from the main one in those and implement the ones that are needed to run some tests to create some example found in the library of the reproschema repo itself |
23e57db
to
61310c8
Compare
@Remi-Gau - we will be getting back to this soon. a new person has joined our group. i wanted to check in on the status. a few questions:
|
status after playing around with attrs I indeed started switching to pydantic as I was already adding tons of type hints... but then I had to go back to do other things.
Not really except for the fact that if we want to deploy documentation useful for devs it will be much easier with sphinx given its autodoc features.
yeah those should probably go away and be included as doc strings in the top of the relevant modules |
thanks @Remi-Gau - there are a few new kid techs on the block that may make our lives even easier. i'll see where we can take this soon. |
TODO
unrelated changes