RSDEV-427 Analytics events for the new gallery #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to the RSpace open-source project! We're excited to have you here! To get started and learn more about the project, our code of conduct and contributor guidelines, please visit https://github.com/rspace-os/rspace-web/wiki
|
@tilorspace Before I do too many, any feedback on the naming of the events? |
|
@rlamacraft I haven't looked at all events, but user:uploaded:file:gallery for example looks good to me using actor:verb:object:target; there was however another one user:created:gallery:folder, which accordingly should be switched to user:created:folder:gallery. |
rlamacraft
force-pushed
the
rsdev-427-analytics
branch
3 times, most recently
from
1c49bd2 to
d3913b3
Compare
This should have been removed by commit ea6fbe2, when it replaced the mechanism for opening folders.
rlamacraft
force-pushed
the
rsdev-427-analytics
branch
from
833bd53 to
a503bf3
Compare
If the rename operation fails then we do not want to update the locally stored name otherwise we end up in a corrupted local state.
rlamacraft
force-pushed
the
rsdev-427-analytics
branch
from
fec454f to
9534a14
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.