From f907ad43455a5a201f406b9eb5fa841c59909ae4 Mon Sep 17 00:00:00 2001 From: Michael Skiba Date: Fri, 6 Jan 2017 11:19:15 -0500 Subject: [PATCH 1/2] minor fix to make sure all paths use the function to create a gallery item for better loading indicator overriding MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit make sure all page creation flows use “createNewPage” --- RIGImageGallery.podspec | 2 +- RIGImageGallery/Assets/Info.plist | 2 +- RIGImageGallery/RIGImageGalleryViewController.swift | 4 ++-- RIGImageGalleryDemo/Assets/Info.plist | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/RIGImageGallery.podspec b/RIGImageGallery.podspec index b0f6151..24455f2 100644 --- a/RIGImageGallery.podspec +++ b/RIGImageGallery.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "RIGImageGallery" - s.version = "0.3.0" + s.version = "0.3.1" s.summary = "An image gallery view controller designed to work with the Raizlabs Interface Guidelines for iOS." s.description = <<-DESC diff --git a/RIGImageGallery/Assets/Info.plist b/RIGImageGallery/Assets/Info.plist index f42ccf5..7e82fe1 100644 --- a/RIGImageGallery/Assets/Info.plist +++ b/RIGImageGallery/Assets/Info.plist @@ -15,7 +15,7 @@ CFBundlePackageType FMWK CFBundleShortVersionString - 0.3.0 + 0.3.1 CFBundleSignature ???? CFBundleVersion diff --git a/RIGImageGallery/RIGImageGalleryViewController.swift b/RIGImageGallery/RIGImageGalleryViewController.swift index 5a34cb8..eaac870 100644 --- a/RIGImageGallery/RIGImageGalleryViewController.swift +++ b/RIGImageGallery/RIGImageGalleryViewController.swift @@ -87,7 +87,7 @@ open class RIGImageGalleryViewController: UIPageViewController { setViewControllers([UIViewController()], direction: .forward, animated: animated, completion: nil) return } - let newView = RIGSingleImageViewController(viewerItem: images[currentImage]) + let newView = createNewPage(for: images[currentImage]) let direction: UIPageViewControllerNavigationDirection if self.currentImage < currentImage { direction = .forward @@ -162,7 +162,7 @@ open class RIGImageGalleryViewController: UIPageViewController { super.viewWillAppear(animated) updateBarStatus(animated: false) if currentImage < images.count { - let photoPage = RIGSingleImageViewController(viewerItem: images[currentImage]) + let photoPage = createNewPage(for: images[currentImage]) setViewControllers([photoPage], direction: .forward, animated: false, completion: nil) } } diff --git a/RIGImageGalleryDemo/Assets/Info.plist b/RIGImageGalleryDemo/Assets/Info.plist index 2a537b6..09a664a 100644 --- a/RIGImageGalleryDemo/Assets/Info.plist +++ b/RIGImageGalleryDemo/Assets/Info.plist @@ -15,7 +15,7 @@ CFBundlePackageType APPL CFBundleShortVersionString - 0.3.0 + 0.3.1 CFBundleSignature ???? CFBundleVersion From 57147403b4c43f9d2840663259c7b3607cb97ef8 Mon Sep 17 00:00:00 2001 From: Michael Skiba Date: Mon, 9 Jan 2017 10:03:37 -0500 Subject: [PATCH 2/2] minor timing improvement --- RIGImageGallery/RIGImageGalleryViewController.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RIGImageGallery/RIGImageGalleryViewController.swift b/RIGImageGallery/RIGImageGalleryViewController.swift index eaac870..b80c66e 100644 --- a/RIGImageGallery/RIGImageGalleryViewController.swift +++ b/RIGImageGallery/RIGImageGalleryViewController.swift @@ -301,7 +301,7 @@ private extension RIGImageGalleryViewController { navigationController?.setToolbarHidden(navigationBarsHidden, animated: animated) navigationController?.setNavigationBarHidden(navigationBarsHidden, animated: animated) setNeedsStatusBarAppearanceUpdate() - UIView.animate(withDuration: 0.15, animations: { + UIView.animate(withDuration: 0.2, animations: { self.currentImageViewController?.scrollView.baseInsets = self.scrollViewInset }) }