Skip to content

Commit 4a79c35

Browse files
authored
Merge pull request nationalparkservice#63 from RobLBaker/master
Cleanup
2 parents c87682f + 2b63bd7 commit 4a79c35

17 files changed

+11
-451
lines changed

DESCRIPTION

-3
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,11 @@ Remotes:
2222
nationalparkservice/DPchecker,
2323
nationalparkservice/QCkit
2424
Imports:
25-
EML,
2625
dplyr,
2726
httr,
2827
XML,
2928
curl,
3029
tools,
31-
rlang,
3230
readr,
3331
magrittr,
3432
crayon,
@@ -37,7 +35,6 @@ Imports:
3735
QCkit (>= 0.1.4),
3836
here,
3937
jsonlite,
40-
cli,
4138
purrr,
4239
tibble,
4340
lifecycle

NAMESPACE

+1-2
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,10 @@ export(load_core_metadata)
2020
export(load_data_package)
2121
export(load_data_package_deprecated)
2222
export(load_data_packages)
23-
export(load_domains)
2423
export(load_pkg_metadata)
2524
export(map_wkt)
2625
export(rm_local_packages)
2726
export(summarize_packages)
28-
export(validate_data_package)
2927
importFrom(lifecycle,deprecated)
3028
importFrom(magrittr,"%>%")
29+
importFrom(stats,na.omit)

NEWS.md

+3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# NPSutils 0.3.3 (under development)
22

3+
##2024-12-19
4+
* remove `validate_data_package()` as this function was listed as "still under construction" is mostly obsolete given other functions and functions in the DPchecker package.
5+
* remove `load_domains()` as this function was not working properly and was conceived of before the data package specifications were properly set.
36
## 2024-12-19
47
* updated `load_pkg_metadata` to be simpler and essentially call `DPchecker::load_metadata` but with a preset default directory structure that works well with the default settings for `get_data_package`.
58
* Add meta-analysis functions for finding and producing summary statistics multiple data packages including `get_ref_list`, `get_refs_info()`, and `summarize_packages`.

R/load_domains.R

-122
This file was deleted.

R/map_wkt.R

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
#'
1212
#' @return The function returns a dynamic, zoomable leaflet map with the specific geometry plotted.
1313
#' @importFrom magrittr %>%
14+
#' @importFrom stats na.omit
1415
#' @export
1516
#'
1617
#' @examples

R/meta_analyses.R

+1-1
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ get_refs_info <- function (reference_type = "dataPackage",
138138
#'
139139
#' If a data package fails to download (or load) into R, the function will return NAs instead of summary data about the data package as well as a message about the package status ("Loads", "Error") in the dataframe that the function returns. The function will ignore files that fall outside the data package specifications (one or more .csv files and a single .xml file ending in *_metadata.xml).
140140
#'
141-
#' When `check_metadata` is set to the default `FALSE`, the function will attempt to and load any .csv, regardless of the contents. Data packages with restricted access can produce false positives if you do not have the appropriate permissions to download the data as the function will still download the files, but they will be populated with unhelpful hmtl rather than the intended data. Functions that fail to load into R likely violate the data package specifications in some fundamental way (e.g. .CSV file instead of .csv or no .csv files at all).
141+
#' When `check_metadata` is set to the default `FALSE`, the function will attempt to and load any .csv, regardless of the contents. Data packages with restricted access can produce false positives if you do not have the appropriate permissions to download the data as the function will still download the files, but they will be populated with unhelpful hmtl rather than the intended data. In this case, each .csv will be listed as having 5 columns and one row of data. Functions that completely fail to load into R likely violate the data package specifications in some fundamental way (e.g. .CSV file instead of .csv or no .csv files at all).
142142
#'
143143
#' When `check_metadata` is set to `TRUE`, additional checks and tests are run on the data package and load errors may occur for all of the above reasons and also if there are multiple .xml files, if the metadata file name does not end in "*_metadata.xml", if there is no metadata file, or if the metadata file is EML schema-invalid.
144144
#'

R/utils.R

+2-1
Original file line numberDiff line numberDiff line change
@@ -63,5 +63,6 @@ globalVariables(c("capture.output",
6363
"metaformat",
6464
"data_format",
6565
"metadata_format",
66-
"fileList"
66+
"fileList",
67+
"attributeName"
6768
))

R/validateDataPackage.R

-24
This file was deleted.

docs/news/index.html

+1-14
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/pkgdown.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ pkgdown: 2.1.0
33
pkgdown_sha: ~
44
articles:
55
NPSutils: NPSutils.html
6-
last_built: 2024-12-20T18:46Z
6+
last_built: 2024-12-23T17:12Z

docs/reference/index.html

-8
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)