Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apply file type filter/search function correctly in groups and direct chats #35091

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

SinghaAnirban005
Copy link
Contributor

@SinghaAnirban005 SinghaAnirban005 commented Feb 2, 2025

Proposed changes (including videos or screenshots)

This PR fixes an issue where the file type filter in group chats was not working correctly. Previously, selecting a file type from the dropdown would display all files instead of filtering based on the selected type. This update ensures that only the selected file type is displayed.

Test.-.Singha.-.Brave.2025-02-02.17-49-51.mp4

Now Search in groups works fine...

Test.-.Singha.-.Brave.2025-02-03.10-50-16.mp4

In case of file search and filtering in direct messages

rajesh.-.Singha.-.Brave.2025-02-03.11-46-01.mp4

Issue(s)

Closes #34930 #35090

Steps to test or reproduce

  1. Open a group chat in Rocket.Chat.
  2. Navigate to the files section.
  3. Click on the dropdown to filter files by type.

Further comments

Copy link

changeset-bot bot commented Feb 2, 2025

⚠️ No Changeset found

Latest commit: 5315861

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@SinghaAnirban005 SinghaAnirban005 requested review from a team as code owners February 3, 2025 07:15
@SinghaAnirban005 SinghaAnirban005 changed the title fix: Apply file type filter correctly in groups fix: Apply file type filter/search function correctly in groups and direct chats Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search function for file names in groups and direct messages not working
1 participant