-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rooms.media API endpoint only upload file but does not send message #34956
Comments
This isn't a really a bug but a feature request. I'll try and ask for a comment why this has changed. Don't expect a fast response. |
Asked internal engineers to take a look |
Hey, I am currently working on this issue and want to clarify if |
Hello, yes this is exactly what I want to do, just like the current API (rooms.upload) with the |
You should never start working on any issue until you have asked on open #support Read all this please: https://gist.github.com/reetp/b0ba4e3d0ea2ff48ca9da00a5a647d42#github Note that Casals has referred this to the internal teams:
You need to wait for the outcome of that first. This may be something they want fixed, it may be something they do themselves, or it maybe something they removed on purpose and do not intend fixing. You'll just have to wait. |
I have implemented this locally. Just let me know the what is the response of the internal engineers |
I asked team to check here. It's on their agenda to get back |
hey @mkandel-lockself! thanks for reaching out! after investigating, i can confirm that the if you need to trigger a notification about the media being uploaded to a channel, you'll need to call the from the perspective of allowing you guys to make a pull request suggesting a change to this behavior, although i think it’s a great idea, we won’t be able to accept it into the product soon. this is due to potential conflicts and breaking changes within our existing ecosystem. moves like this often require some product roadmap planning to phase out an existing behavior in order to introduce a new one. let me know if you have any other questions! |
Thank you for your clarification. |
@ricardogarim I have checked some of the issues but it seems that many of the potential issues are meant to be fixed by internal team. Can you please ping me in the issues where we ( contributers ) can add our contribution. |
Don't Please read this about issues. No one is going to sit and walk you thorough this. Please look on https://open.rocket.chat in teh gsoc2025 team. |
I understand, the functionality that allows users to send a message with a file (e.g. |
Can't see it there - you might want to have a search in the code in case it is there but not yet documented. Hopefully one of the team will let you know soonest. |
Description:
The rooms.media API endpoint does not send a message, but only uploads the file to the channel. Unlike rooms.upload, which does send a message but will be obsolete in version 8.0.0.
Steps to reproduce:
...
>Files
but not the message in the feed.Expected behavior:
A message sended with a notification like
rooms.upload
endpoint.Actual behavior:
The file is uploaded but no message are sent.
Server Setup Information:
Client Setup Information
Additional context
I noticed in the code that for the rooms.media route there is no message sending, unlike the rooms.upload route.
The text was updated successfully, but these errors were encountered: