Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Login and Account Creation Behavior in Rocket.Chat login page #35197

Open
Anxhul10 opened this issue Feb 13, 2025 · 0 comments
Open

Comments

@Anxhul10
Copy link

Anxhul10 commented Feb 13, 2025

Description:

There are inconsistencies in the login and account creation process, particularly when using the "Sign in with Google" option and then attempting to log in using email/username and password. The following behaviors are observed:

  1. Sign in with Google (without setting a password)
    (already created an account and entered the username).

    • Expected: Attempting to log in with email/username should return an error indicating that the account does not have a password.

    • Actual: The error returned is "User not found."

    • sign.in.without.setting.password.webm
  2. Sign in with Google (after setting a password)

    • Expected: Logging in using email/username and password should work.

    • Actual: "User not found" error appears, and no logs are generated.

    • after.setting.password.webm
  3. Account Creation and Username/Email Handling Issues :
    ( note : This method is performed when I have already created an account using sign in with google and then I have tried to create an account)

    • If trying to create an account with an existing email but a unique username:

    • Expected: A UI error stating "Email is already in use. Try a different email."

    • log : The error message is unclear: {success: false, error: 'Something went wrong. Please check your credentials. [403]', errorType: 403}.

    • unique.username.create.account.webm

Steps to reproduce:

  1. Go to the login page.

  2. Sign in using Google without setting a password.

  3. Try logging in using email/username.

  4. Observe the "User not found" error instead of a "No password set" error.

  5. Set a password and try logging in with email/username.

  6. Observe that the error "User not found" persists with no logs.

  7. Attempt to create an account with an existing username.

  8. Observe that the UI correctly shows "Username already exists."

  9. Attempt to create an account with an existing email but a unique username.

  10. Observe that the error message is unclear (Something went wrong. Please check your credentials. [403]).

Expected behavior:

  • When logging in with email/username without setting a password, the system should return an error indicating "This account doesn't have a password!" instead of "User not found."

  • When logging in after setting a password, authentication should succeed if credentials are correct; otherwise, an appropriate error should be displayed.

*If the email is already registered, the UI should clearly state "Email is already in use. Try a different email." instead of a generic error.

Actual behavior:

  • "User not found" error appears in cases where a "No password set" error is expected.

  • Logging in after setting a password still results in "User not found" with no logs.

  • The error message for duplicate email registration is unclear (Something went wrong. Please check your credentials. [403]).

Server Setup Information:

  • using open.rocket.chat

Client Setup Information

  • Desktop App or Browser Version: google and firefox
  • Operating System:Ubuntu 24.04.1 LTS

Additional context

Relevant logs:

  1. Sign in with Google (without setting a password):
    no logs generated.
  2. Sign in with Google (after setting a password):
    no logs are generated.
  3. Account Creation and Username/Email Handling Issues:
     ### Error Log from `verifyErrors.js:34` ```json { "success": false, "error": "Something went wrong. Please check your credentials. [403]", "errorType": 403, "user": { "name": "dummy", "email": "dummyId296@gmail.com", "username": "dum.dum.unique", "pass": "No_pass123." } } ``` 

Proposed fixes

🔹 Fix 1: Upon login using email/username and password without setting up the password should give me this account does not have a password
🔹 Fix 2: Ensure Authentication Works After Setting a Password .
🔹 Fix 3: Improve Error Messages for Duplicate Email Registration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants