update for pyopenms 3.2.0 #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename PeakPickerMRM to PeakPickerChromatogram
exclude plotly tests on mac and windows due to different results
seems that tests in mac still failing so different from windows
was not skipping on mac
update everything to v5
possibly version dependencies will be better if use .toml
do not use flit
also update snapshots for new plotly
update peak picker docs to fix the broken links
singjc
approved these changes
Oct 4, 2024
| @@ -43,6 +43,7 @@ def test_plot_3d_vline(featureMap, snapshot_plotly): | |||
| fig = plotter.plot(featureMap) | |||
| assert snapshot_plotly == fig | |||
|
|
|||
| @pytest.mark.skipif(sys.platform == 'darwin', reason="Plots slightly different on mac") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contents (#138)
Other
Uncategorised!