Patch/sq mass loader low mem #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
library access is not needed for SqMassLoader, so move to MzMLLoader. This saves both loading time and memory
remove hashtables or only initiate hashtables if needed
fix tests now that result file does not require a library
this is quite convienient in a jupyter notebook setting when using the plotChromatograms() function. In this case, the chromatograms do not have to be loaded from disk because they are already present.
theoretically a library would be needed for extraction in any SpectrumLoader, (not just .mzml) so move the library checks to the abstract class
singjc
approved these changes
Oct 30, 2024
|
I fixed the docs failing so should be good to merge now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contents (#154)
Other
Uncategorised!