check_sqlite_table: also check if entires in table #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code that uses this funciton assume the table is present and sometimes also that there are entries in the table (table is not empty). To ensure this does not crash in instances where the table is present but is empty, also check that the table is not empty.
singjc
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
code that uses the
check_sqlite_tablefunction assume check is if the table is present and sometimes also that there are entries in the table (table is not empty). To ensure this does not crash in instances where the table is present but is empty, also check that the table is not empty.Fixes # (issue)
Please delete options that are not relevant.
Contents (#155)
Other