Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: DIA-NN XIC parquet access #175

Merged
merged 7 commits into from
Feb 26, 2025
Merged

Conversation

jcharkow
Copy link
Collaborator

@jcharkow jcharkow commented Feb 20, 2025

Description

Add loader/access to DIA-NN XIC Parquet file. This is tested with DIA-NN 1.9.2

Tests have also been added

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Contents (#175)

Other

  • Loading of DIA-NN Parquet XICs
  • add tests for diann xic parquet file loading
  • add XICParquetDataAccess to docs

Uncategorised!

  • add pyarrow as dependency
  • update docs
  • remove pyarrow requirements
  • Update massdash/loaders/XICParquetDataLoader.py

Add XICParquetDataLoader and XICParquetDataAccess for accessing DIA-NN
chromatograms stored in parquet
update API docs to include the new class
had manual pyarrow but pyarrow was alrfeady present
Copy link
Collaborator

@singjc singjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool addition! Looks good to me

Co-authored-by: Justin Sing <32938975+singjc@users.noreply.github.com>
@jcharkow jcharkow merged commit 7473914 into dev Feb 26, 2025
1 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants