-
Notifications
You must be signed in to change notification settings - Fork 17
Updates to Swift 3.0 and RxSwift 3.0 #5
base: master
Are you sure you want to change the base?
Conversation
3104f91
to
05ce625
Compare
I think it should now be ok, I've fixed linker errors. |
I'm planning to use this library this addition will be awesome. Any thoughts about when will it be merged? |
👍 I'm quite interested in using RxFirebase and contributing to it. A work project already uses Firebase and RxSwift, but not the two together, so we're a prime candidate to adopt this. That said, the work represented in this PR is a must since I've already pushed us through the migration to Swift 3, etc. |
Hi guys, this PR has issues that it causes duplicate symbols warning. I think we are still waiting for firebase dynamic library dependency. Until then you can just copy paste those critical couple of lines. |
Maybe it would help to bring this issue up on the Firebase google group (https://groups.google.com/forum/#!forum/firebase-talk)? I can do it but I'll need a clear understanding of the issue... it seems that the warnings arise from the Firebase framework being included in both the RxFirebase framework and also the App... |
Yes @acchou. It duplicate the links because Firebase is distributed as a static library. When it's linked to RxFirebase to generate the .framework package it includes all code from Firebase inside. I tried different build configurations without success. My final solution was to include the RxFirebase code into my project directly and use Firebase from Cocoapods. |
I solved it with a work a round to only include the RxFramework pod. pod 'RxFirebase', path: '~/RxFirebase/RxFirebase.podspec' Does anyone know if there are any references that a framework version for the firebase libs is planned? |
Hey guys, are you going to merge this? |
We can't merge it until Firebase releases a dynamic library. |
Hi,
I've made some adaptations for Swift 3.0 and RxSwift 3.0.
First commit is updating Podfiles.
Second commit are real changes.
I think there are still issues with CocoaPods and Firebase, but at least it now compiles because I've manually patched the Pods projects.