Skip to content
This repository was archived by the owner on Apr 7, 2018. It is now read-only.

Updates to Swift 3.0 and RxSwift 3.0 #5

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

kzaher
Copy link
Member

@kzaher kzaher commented Dec 7, 2016

Hi,

I've made some adaptations for Swift 3.0 and RxSwift 3.0.

First commit is updating Podfiles.
Second commit are real changes.

I think there are still issues with CocoaPods and Firebase, but at least it now compiles because I've manually patched the Pods projects.

@kzaher kzaher force-pushed the master branch 3 times, most recently from 3104f91 to 05ce625 Compare December 7, 2016 11:33
@kzaher
Copy link
Member Author

kzaher commented Dec 7, 2016

I think it should now be ok, I've fixed linker errors.

@leoneparise
Copy link

I'm planning to use this library this addition will be awesome. Any thoughts about when will it be merged?

@jwhitley
Copy link

👍 I'm quite interested in using RxFirebase and contributing to it. A work project already uses Firebase and RxSwift, but not the two together, so we're a prime candidate to adopt this. That said, the work represented in this PR is a must since I've already pushed us through the migration to Swift 3, etc.

@kzaher
Copy link
Member Author

kzaher commented Jan 1, 2017

Hi guys,

this PR has issues that it causes duplicate symbols warning. I think we are still waiting for firebase dynamic library dependency.

Until then you can just copy paste those critical couple of lines.

@acchou
Copy link

acchou commented Jan 3, 2017

Maybe it would help to bring this issue up on the Firebase google group (https://groups.google.com/forum/#!forum/firebase-talk)? I can do it but I'll need a clear understanding of the issue... it seems that the warnings arise from the Firebase framework being included in both the RxFirebase framework and also the App...

@leoneparise
Copy link

leoneparise commented Jan 5, 2017

Yes @acchou. It duplicate the links because Firebase is distributed as a static library. When it's linked to RxFirebase to generate the .framework package it includes all code from Firebase inside. I tried different build configurations without success.

My final solution was to include the RxFirebase code into my project directly and use Firebase from Cocoapods.

@pietgk
Copy link

pietgk commented Feb 27, 2017

I solved it with a work a round to only include the RxFramework pod.
I did create my own fork (pietgk/RxFramework) with this pull request included and referencing it locally:

pod 'RxFirebase', path: '~/RxFirebase/RxFirebase.podspec'

Does anyone know if there are any references that a framework version for the firebase libs is planned?

@OSemenovBoyarka
Copy link

Hey guys, are you going to merge this?

@kzaher
Copy link
Member Author

kzaher commented Jul 26, 2017

We can't merge it until Firebase releases a dynamic library.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants