Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SK-189 Add images support for profile #120

Merged
merged 13 commits into from
Jul 11, 2024
Merged

SK-189 Add images support for profile #120

merged 13 commits into from
Jul 11, 2024

Conversation

Oleksandr1414
Copy link
Collaborator

No description provided.

@IgorKhomenko
Copy link
Contributor

IgorKhomenko commented Jul 2, 2024 •
edited
Loading

@Oleksandr1414 I have a more general thing to discuss regarding performance and possible optimizations.

It's probably make sense to try to reduce the amount of 'getAvatarUrl' requests by providing this data as a part of others requests which we already perform. For example, maybe we can return avatar object (with prebuilt url) as a part of get_participants_by_cids so in this case we can reduce some noise at client-side.

And in future we can do the same trick for conversation_list request

@artem-yatchenko artem-yatchenko merged commit 2e632d4 into main Jul 11, 2024
@Oleksandr1414 Oleksandr1414 deleted the SK-189-support-profile-images branch July 16, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorKhomenko IgorKhomenko IgorKhomenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Oleksandr1414 @IgorKhomenko @artem-yatchenko