fix(executeATCCheck): correctly escape namespaces #5275
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ATC check failed when the name of a development object included a
namespace. Prior to this change, the generated request body looked like
this:
...
<adtcore:objectReferences>
<adtcore:objectReference
adtcore:uri="/sap/bc/adt/ddic/tables//ABC/MY_TABLE/source/main" />
<adtcore:objectReference
adtcore:uri="/sap/bc/adt/oo/interfaces//ABC/MY_INTERFACE" />
</adtcore:objectReferences>
...
Due to the unescaped slashes in the namespace, the SAP system failed
with a 400 Bad Request error:
URI-Mapping cannot be performed due to invalid URI:
/sap/bc/adt/ddic/tables//ABC/MY_TABLE/source/main
By ensuring the namespaces are properly escaped (e.g. %2FABC%2FMY_TABLE)
for all object types, the ATC check now works as expected. However, for
classes this issue was already fixed in commit 4ff5271
(gCTSExecuteABAPQualityCheck_namespace_objects (SAP#4623), 2023-10-11).
|
|
Thank you for your contribution! This pull request is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add |
|
This pull request is still relevant, it fixes the issue described in #5324. @SAP/jenkins-library-team I would really appreciate if some could take a look at this pull request or the associated issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ATC check failed when the name of a development object included a namespace. Prior to this change, the generated request body looked like this:
Due to the unescaped slashes in the namespace, the SAP system failed with a 400 Bad Request error:
By ensuring the namespaces are properly escaped (e.g.
%2FABC%2FMY_TABLE) for all object types, the ATC check now works as expected. However, for classes this issue was already fixed in commit 4ff5271 (gCTSExecuteABAPQualityCheck_namespace_objects (#4623), 2023-10-11).Checklist