Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant error log thrown when an optional subaccount secret does not exist #469

Closed
szwedm opened this issue Oct 7, 2024 · 2 comments
Closed

Comments

@szwedm
Copy link

szwedm commented Oct 7, 2024

The following error is visible in the controller logs even when only the default secret should be used for service instances management:

sr.Log.Error(err, fmt.Sprintf("Could not fetch secret %s from management namespace %s", name, sr.ManagementNamespace))
.
The error is ignored later:
if client.IgnoreNotFound(err) != nil {

and the controller picks the default secret for further operations.

@I065450
Copy link
Collaborator

I065450 commented Oct 7, 2024

I will change the log level to info.

@I065450
Copy link
Collaborator

I065450 commented Oct 7, 2024

#470

@I065450 I065450 closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants