Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

FE: API, Code Cleanup & Fixes #222

Merged
merged 18 commits into from
Jun 8, 2024
Merged

FE: API, Code Cleanup & Fixes #222

merged 18 commits into from
Jun 8, 2024

Conversation

benniloidl
Copy link
Contributor

No description provided.

@benniloidl benniloidl requested a review from Jozys June 6, 2024 08:45
@Jozys
Copy link
Collaborator

Jozys commented Jun 6, 2024

Please provide a description of what you changed in this PR.

@Integraluminium Integraluminium self-requested a review June 6, 2024 17:40
@benniloidl
FE: Making Buttons look way cooler!
fb6f151 
And fixing some styling issues
Integraluminium
Integraluminium suggested changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@Integraluminium Integraluminium left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are many changes, which are a bit confusing to look at.
Please check license for the pictures and export for i18n.

Have you tested usability on firefox?

@benniloidl
Copy link
Contributor Author

The requests have been implemented (even though they did not regard the changes in this PR).

@Integraluminium
Copy link
Collaborator

Looks good for me,

  • Internal server error is fixed in Backend/urgent fixes #227 due to errors in backend
  • The button to post answers is missing, please fix in next PR
  • I18n is provided partly, please move on and extract more elements into the language file

Integraluminium
Integraluminium approved these changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@Integraluminium Integraluminium left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review last comment

@benniloidl benniloidl merged commit 43a4ec7 into main Jun 8, 2024
3 checks passed
@benniloidl benniloidl deleted the frontend/api branch June 8, 2024 07:06
@Jozys Jozys removed their request for review June 9, 2024 15:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Integraluminium Integraluminium Integraluminium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benniloidl @Jozys @Integraluminium