v1.2

Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>

Author: DiegoAndresCortes

Sources/SimpleReferrals.php

@@ -2,7 +2,7 @@
 
 /**
  * @package Simple Referrals
- * @version 1.0
+ * @version 1.2
  * @author Diego Andrés <diegoandres_cortes@outlook.com>
  * @copyright Copyright (c) 2021, SMF Tricks
  * @license https://www.gnu.org/licenses/gpl-3.0.en.html
@@ -82,6 +82,9 @@ public static function save_referral(&$regOptions, &$theme_vars, &$knownInts)
 					$smcFunc['db_free_result']($request);
 				}
 
+				// Update the session with the input user? I don't think it's relevant for the mod, but will leave here just in case
+				// $_SESSION['signup_referral'] = (int) self::$_member_id;
+
 				// Insert the value
 				$regOptions['register_vars']['referral'] = self::$_member_id;
 
@@ -115,6 +118,10 @@ public static function update_count($regOptions)
 				]
 			);
 		}
+
+		// If we still have the referral in the session, remove it
+		if (isset($_SESSION['signup_referral']))
+			unset($_SESSION['signup_referral']);
 	}
 
 	/**
@@ -129,21 +136,15 @@ public static function register()
 	{
 		global $context, $txt, $modSettings;
 
-		// Help SMF remember the referral
-		if (!empty($context['agreement']) || !empty($context['privacy_policy']))
-		{
-			if (!empty($context['agreement']))
-				$context['agreement'] .= '<input type="hidden" name="referral" value="' . (isset($_REQUEST['referral']) && !empty($_REQUEST['referral']) ? (int) $_REQUEST['referral'] : '') . '">';
-			else
-				$context['privacy_policy'] .= '<input type="hidden" name="referral" value="' . (isset($_REQUEST['referral']) && !empty($_REQUEST['referral']) ? (int) $_REQUEST['referral'] : '') . '">';
-		}
+		// Save the referral in the session
+		$_SESSION['signup_referral'] = (int) (isset($_REQUEST['referral']) && !empty($_REQUEST['referral']) ? $_REQUEST['referral'] : (isset($_SESSION['signup_referral']) && !empty($_SESSION['signup_referral']) ? $_SESSION['signup_referral'] : 0));
 
 		// Auto suggest
 		loadJavaScriptFile('suggest.js', array('defer' => false, 'minimize' => true), 'smf_suggest');
 
-		// Do we have a referrer in the url?
-		if (!empty($_REQUEST['referral']) && isset($_REQUEST['referral']))
-			self::$_member_id = (int) $_REQUEST['referral'];
+		// Do we have a referrer in the session/url?
+		if (!empty($_SESSION['signup_referral']) && isset($_SESSION['signup_referral']))
+			self::$_member_id = (int) $_SESSION['signup_referral'];
 		// Maybe we are returning to some errors?
 		elseif (!empty($_REQUEST['simple_referrer_id']) && isset($_REQUEST['simple_referrer_id']))
 			self::$_member_id = (int) $_REQUEST['simple_referrer_id'];

Themes/default/languages/SimpleReferrals/.english.php

@@ -18,7 +18,7 @@
 $txt['maintain_recountreferrals_info'] = 'Run this maintenance task to update your users referral count. It will recount all (countable) referrals they have and then update their profile referral totals';
 $txt['SimpleReferrals_settings'] = 'Simple Referrals Settings';
 $txt['SimpleReferrals_allow_select'] = 'Only allow direct links';
-$txt['SimpleReferrals_allow_select_desc'] = 'If enabled, guests will not be able to find/set forum users in the signup form, can only use direct referral links.';
+$txt['SimpleReferrals_allow_select_desc'] = 'If enabled, guests will not be able to search/set forum users in the signup form, can only use direct referral links.';
 $txt['SimpleReferrals_enable_posts'] = 'Enable referrals count in posts';
 $txt['SimpleReferrals_enable_profile'] = 'Enable referrals count in profile';
 $txt['SimpleReferrals_display_link'] = 'Display the referral link in profile';

package-info.xml

@@ -3,7 +3,7 @@
 <package-info xmlns="http://www.simplemachines.org/xml/package-info" xmlns:smf="http://www.simplemachines.org/">
 	<id>smftricks:simplereferrals</id>
 	<name>Simple Referrals</name>
-	<version>1.1</version>
+	<version>1.2</version>
 	<type>modification</type>
 	<install for="2.1 - 2.1.99, 2.1 RC4">
 		<!-- Mod Readme -->