Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign website #1332

Merged
merged 30 commits into from
Feb 6, 2025
Merged

Conversation

bbartholdy
Copy link
Contributor

@bbartholdy bbartholdy commented Feb 4, 2025

Pull Request

This PR is for a website redesign. Preview can be found here: https://bbartholdy.github.io/AncientMetagenomeDir/#/

@bbartholdy bbartholdy requested a review from jfy133 February 4, 2025 21:28
Copy link
Collaborator

@alexhbnr alexhbnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the great work, @bbartholdy! I just left a few suggestions where I think a bit more than a single word would be helpful.

Overall, there is quite a bit of potential revise the material so let's hope we make some good progress during the hackathon.

bbartholdy and others added 4 commits February 6, 2025 11:40
Incorporate feedback to main README

Co-authored-by: Alex Hübner <alexhbnr@gmail.com>
Co-authored-by: Alex Hübner <alexhbnr@gmail.com>
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last few things, otherwise this is good enough to merge from PoV.

only quesiton is if the C14 team want the C14 docs already in? @aidaanva @KaHea-21 ?

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
@bbartholdy
Copy link
Contributor Author

Last few things, otherwise this is good enough to merge from PoV.

only quesiton is if the C14 team want the C14 docs already in? @aidaanva @KaHea-21 ?

Maybe better as a separate branch? This PR might get too unruly otherwise

bbartholdy and others added 4 commits February 6, 2025 14:18
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
@bbartholdy bbartholdy merged commit 63d0eda into SPAAM-community:master Feb 6, 2025
1 check failed
@bbartholdy bbartholdy deleted the redesign-website branch February 7, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants