Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C14 Key2020 #1358

Merged
merged 15 commits into from
Feb 7, 2025
Merged

C14 Key2020 #1358

merged 15 commits into from
Feb 7, 2025

Conversation

KaHea-21
Copy link
Contributor

@KaHea-21 KaHea-21 commented Feb 7, 2025

Pull Request

To update issue #1235

C14 data needs reviewing and entered into missing fields

Need to add to changelog

This PR is for a

For the following list(s):

  • ancientmetagenome-environmental (README)
  • ancientmetagenome-hostassociated (README)
  • ancientsinglegenome-hostassociated (README)

This is to close

PR Workflow

  1. Open this PR with sample metadata on the samples metadata sheet (:tada: you're already here!)
  2. Wait for checks for sample metdata to pass
  3. (If checks fail) make corrections, and push changes to this branch (no need to open a new PR!)
  4. (Once passed) comment on this PR @spaam-bot please autofill <table_name> <project_id> to get a half-filled template! (may take a minute or so to get the comment with the file)
  5. Fill in the template, and verify autofilled data correct!
  6. Once filled in, append(!) the new rows from the TEMPLATE file to the end of the corresponding library metadata file, and update this PR
  7. Wait for checks for library metadata to pass
  8. Request review!

Pre-review checklist (new publications)

  • Publication is published
    • Preprints currently not accepted?
  • Checked the publication is not already in the database?
  • Checked samples in this publication are not previously published data?
    • Newly re-sequenced metagenomes are OK!
  • Samples are shotgun metagenomes and not amplicon data
    • Note: hostassociated-singlegenome may also contain whole-genome enriched data
  • Checked the list follows conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)?
  • Once sample table validation completed Library metadata has been added
    • Use @spaam-bot please autofill <table_name> <project_id> to get a half-filled template! May take a minute or so to get the comment with the file
    • Fill in template, and verify autofill data correct!
    • Once filled in, append(!) the new rows to the end of the corresponding library metadata file
  • Changelog is updated to include the publication under 'Added'?

Key2020 2020 10.1038/s41559-020-1106-9 OBP001 PRJEB35216 ERS3967965 TRUE TRUE DNE FALSE main text 1 10.1038/s41559-020-1106-9 TRUE MAMS 34903 AMS NR NR tooth 4555 21 -99999 -99999 -99999 -99999 TRUE IntCal13 SwissCal 1 NR NR 5317 5068 NA cal BP 2 FALSE DNE DNE NA NA NA NA
Key2020 2020 10.1038/s41559-020-1106-9 SUA004 PRJEB35216 ERS3967966 TRUE TRUE DNE FALSE main text 1 10.1038/s41559-020-1106-9 TRUE MAMS 26902 AMS NR NR tooth 3794 34 -99999 -99999 -99999 -99999 TRUE IntCal13 SwissCal 1 NR NR 4300 4010 NA cal BP 2 FALSE DNE DNE NA NA NA NA
Key2020 2020 10.1038/s41559-020-1106-9 MK3001 PRJEB35216 ERS3967962 TRUE TRUE DNE FALSE main text 1 10.1038/s41559-020-1106-9 TRUE MAMS 29808 AMS NR NR tooth 2831 20 -99999 -99999 -99999 -99999 TRUE IntCal13 SwissCal 1 NR NR 2994 2873 NA cal BP 2 FALSE DNE DNE NA NA NA NA
Key2020 2020 10.1038/s41559-020-1106-9 ETR001 PRJEB35216 ERS3967960 TRUE TRUE DNE TRUE main text 1 10.1038/s41559-020-1106-9 TRUE NR NA AMS NR NR tooth 1811 24 -99999 -99999 -99999 -99999 TRUE IntCal13 SwissCal 1 NR NR 1810 1620 NA cal BP 2 FALSE DNE DNE NA NA NA NA
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure where this date is coming from... I believe that the information should be combined with line 15

iseultj and others added 3 commits February 7, 2025 14:28
Co-authored-by: Aida Andrades Valtueña <aida.andrades@gmail.com>
…ostassociated_dates.tsv

Co-authored-by: Aida Andrades Valtueña <aida.andrades@gmail.com>
@iseultj iseultj requested a review from aidaanva February 7, 2025 13:33
Copy link

github-actions bot commented Feb 7, 2025

amdirt, version 1.6.5

Samples

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_samples.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_samples.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_samples.tsv is valid

Libraries

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_libraries.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_libraries.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_libraries.tsv is valid

Dates

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_dates.tsv is valid

@aidaanva aidaanva merged commit 320803a into master Feb 7, 2025
1 check passed
@aidaanva aidaanva deleted the C14-Key2020 branch February 7, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants