Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RodriguezVarela2024 samples #1372

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

ZoePochon
Copy link
Contributor

@ZoePochon ZoePochon commented Feb 7, 2025

One accession number is missing for a sample on ENA. First author has been contacted.

Pull Request

This PR is for a

For the following list(s):

  • ancientmetagenome-environmental (README)
  • ancientmetagenome-hostassociated (README)
  • ancientsinglegenome-hostassociated (README)

This is to close #1186

PR Workflow

  1. Open this PR with sample metadata on the samples metadata sheet (:tada: you're already here!)
  2. Wait for checks for sample metdata to pass
  3. (If checks fail) make corrections, and push changes to this branch (no need to open a new PR!)
  4. (Once passed) comment on this PR @spaam-bot please autofill <table_name> <project_id> to get a half-filled template! (may take a minute or so to get the comment with the file)
  5. Fill in the template, and verify autofilled data correct!
  6. Once filled in, append(!) the new rows from the TEMPLATE file to the end of the corresponding library metadata file, and update this PR
  7. Wait for checks for library metadata to pass
  8. Request review!

Pre-review checklist (new publications)

  • Publication is published
    • Preprints currently not accepted?
  • Checked the publication is not already in the database?
  • Checked samples in this publication are not previously published data?
    • Newly re-sequenced metagenomes are OK!
  • Samples are shotgun metagenomes and not amplicon data
    • Note: hostassociated-singlegenome may also contain whole-genome enriched data
  • Checked the list follows conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)?
  • Once sample table validation completed Library metadata has been added
    • Use @spaam-bot please autofill <table_name> <project_id> to get a half-filled template! May take a minute or so to get the comment with the file
    • Fill in template, and verify autofill data correct!
    • Once filled in, append(!) the new rows to the end of the corresponding library metadata file
  • Changelog is updated to include the publication under 'Added'?

One accession number is missing for a sample on ENA. First author has been contacted.
@ZoePochon ZoePochon marked this pull request as draft February 7, 2025 12:09
Add accession code for library ldo054 since both libraries of the same individual ldo054 and ldo267 have been merged into one FASTQ file on ENA.
@ZoePochon
Copy link
Contributor Author

@spaam-bot please autofill ancientsinglegenome-hostassociated RodriguezVarela2024

In the libraries the author called the sample ldo054: ldo054+ldo267 but I only kept ldo054 for consistency.
And add the change to singlegenome_species.json as well.
Copy link

github-actions bot commented Feb 7, 2025

amdirt, version 1.6.5

Samples

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_samples.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_samples.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_samples.tsv is valid

Libraries

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_libraries.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_libraries.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_libraries.tsv is valid

Dates

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_dates.tsv is valid

@ZoePochon
Copy link
Contributor Author

First author merged ldo054 library with ldo267 library since it was from the same individual.
Note: Those are uploaded fastq files generally merged at the library level except for ldo054 which was somehow merged at the individual level, maybe to avoid confusion since both libraries of the same individuals were named differently.

@ZoePochon ZoePochon marked this pull request as ready for review February 7, 2025 13:04
@ZoePochon ZoePochon requested a review from alexhbnr February 7, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RodriguezVarela 2024
1 participant