-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLAYNEXT-1271 Display audio shows and medias in square images for the new PAC Audio page #542
base: main
Are you sure you want to change the base?
Conversation
… API and other platforms
… between audio and video content for medias
… `mediaType`
028e98c
to
bd0709c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look at the code but it is difficult for me to provide valuable insights without delving into the implementation and possible alternatives.
A general comment I want to make is that this implementation introduces a lot of surgical layout adjustments, which raises some concerns. I am still asking myself if surgical updates could have been made in less places. Not sure this is possible, though, but without actually doing the work it is quite difficult to say.
Another comment about the layout itself. With the emphasis on show logos as well as the tighter packing of items on screen, I have the impression that the result is more cluttered than what we have today. Of course the data currently displayed might not represent what the result will be after curation, so I might be mislead here.
Description
This is probably the last substantial PR for PAC audio. The rest will be bug fixes and adjustments, unless there's a big change in direction.
The main goal of this PR is to display medias and shows in squared containers.
It was fairly straightforward for
Shows
since there was already a logic in place to display 2/3 posters.However for
Media
it's another story, especially since the associated business object doesn't have any notion ofimageVariant
, but rathermediaType
, and the fact that we have anaudio
media type doesn't mean we have to automatically display it in a squared container (for instance, in the current audio tab nothing should change and in grid collection the 16/9 aspect must be kept).Anyway, I think I cracked it, I will try and see if I can make some adjustments, but your reviews are welcome.
Changes Made
podcast
imageVariant
audio
mediaType
Checklist