Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L ◾ Fixed new line issues on cybersecurity rules #9869

Merged
merged 4 commits into from
Feb 17, 2025
Merged

Conversation

babakamyljanovssw
Copy link
Member

@babakamyljanovssw babakamyljanovssw commented Feb 7, 2025

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️ Found when doing CTF

  1. What was changed?

✏️ Added new line before "✅ Recommended tools:", so it will not stick to previous text when displayed on page.

  1. I paired or mob programmed with:
    ✏️ No

https://www.ssw.com.au/rules/sysadmin-cybersecurity-tools/
image
Figure: "✅ Recommended tools:" is displayed next to text instead of new line

https://www.ssw.com.au/rules/developer-cybersecurity-tools/
image
Figure: "✅ Recommended tools:" is displayed next to text instead of new line

Copy link
Contributor

github-actions bot commented Feb 7, 2025

PR Metrics

Try to keep pull requests smaller than 40 lines of new product code by following the Single Responsibility Principle (SRP).

Lines
Product Code 122
Test Code -
Subtotal 122
Ignored Code -
Total 122

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Fixed new line issues on cybersecurity rules M ◾ Fixed new line issues on cybersecurity rules Feb 7, 2025
@github-actions github-actions bot added Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old labels Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 8, 2025

Howzit @babakamyljanovssw,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@github-actions github-actions bot added Age: 🦖 - Extinct About 128 hours old and removed Age: 🍗 - Ancient About 64 hours old labels Feb 9, 2025
@github-actions github-actions bot changed the title M ◾ Fixed new line issues on cybersecurity rules L ◾ Fixed new line issues on cybersecurity rules Feb 17, 2025
@tiagov8 tiagov8 merged commit 5d2e99c into main Feb 17, 2025
5 checks passed
@tiagov8 tiagov8 deleted the fix-cyber-rules branch February 17, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🦖 - Extinct About 128 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants