Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS ◾ Change from BCC to CC "followupthen" #9927

Merged
merged 3 commits into from
Feb 23, 2025
Merged

XS ◾ Change from BCC to CC "followupthen" #9927

merged 3 commits into from
Feb 23, 2025

Conversation

tiagov8
Copy link
Member

@tiagov8 tiagov8 commented Feb 20, 2025

cc @mishmanners @christianmorfordwaitessw

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

@adamcogan 's email: Re: Rule - Change indentation and add >

  1. What was changed?

from BCC to CC as the standard

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Feb 20, 2025
Copy link
Contributor

github-actions bot commented Feb 20, 2025

PR Metrics

Thanks for keeping your pull request small.

Lines
Product Code 13
Test Code -
Subtotal 13
Ignored Code -
Total 13

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Change from BCC to CC "followupthen" XS ◾ Change from BCC to CC "followupthen" Feb 20, 2025
Copy link
Contributor

Hi @tiagov8,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/follow-up-effectively/rule.md Line 79: column count Rule MD056
rules/follow-up-effectively/rule.md Line 134: list item prefix Rule MD029
rules/follow-up-effectively/rule.md Line 140: list item prefix Rule MD029
rules/follow-up-effectively/rule.md Line 141: list item prefix Rule MD029
rules/follow-up-effectively/rule.md Line 145: list item prefix Rule MD029
rules/follow-up-effectively/rule.md Line 146: list item prefix Rule MD029

Please review and update your Markdown files accordingly.

@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old labels Feb 20, 2025
@tiagov8 tiagov8 enabled auto-merge (squash) February 20, 2025 21:57
Copy link
Member

@uly1 uly1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i disagree. if you cc it, both you AND the client will be sent the follow up. I only want myself to be prompted so then I can follow up the client/dev/whatever myself.
I almost never CC FUT for that reason. i sent it to the to for a future task to mnyself, or the BCC for a reminder to follow up someone else

@github-actions github-actions bot added Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old and removed Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old labels Feb 21, 2025
as per Uly's comment
@tiagov8
Copy link
Member Author

tiagov8 commented Feb 21, 2025

i disagree. if you cc it, both you AND the client will be sent the follow up. I only want myself to be prompted so then I can follow up the client/dev/whatever myself. I almost never CC FUT for that reason. i sent it to the to for a future task to mnyself, or the BCC for a reminder to follow up someone else

Hi @uly1

Agree, I have altered my PR changes to reflect that.
Please review again

@tiagov8 tiagov8 requested a review from uly1 February 21, 2025 12:24
Copy link
Contributor

Hi @tiagov8,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/follow-up-effectively/rule.md Line 79: column count Rule MD056
rules/follow-up-effectively/rule.md Line 134: list item prefix Rule MD029
rules/follow-up-effectively/rule.md Line 140: list item prefix Rule MD029
rules/follow-up-effectively/rule.md Line 141: list item prefix Rule MD029
rules/follow-up-effectively/rule.md Line 145: list item prefix Rule MD029
rules/follow-up-effectively/rule.md Line 146: list item prefix Rule MD029

Please review and update your Markdown files accordingly.

@github-actions github-actions bot added Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ and removed Age: 🐓 - Old About 32 hours old labels Feb 22, 2025
Copy link
Contributor

Howzit @tiagov8,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@github-actions github-actions bot added Age: 🦖 - Extinct About 128 hours old and removed Age: 🍗 - Ancient About 64 hours old labels Feb 23, 2025
@tiagov8 tiagov8 merged commit 0e4d9c4 into main Feb 23, 2025
4 of 5 checks passed
@tiagov8 tiagov8 deleted the tiagov8-patch-25 branch February 23, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🦖 - Extinct About 128 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants