Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some browser errors #1191

Merged
merged 5 commits into from
Jan 2, 2024
Merged

Fixed some browser errors #1191

merged 5 commits into from
Jan 2, 2024

Conversation

BrookJeynes
Copy link
Member

  • Updated StaticQuery to useStaticQuery -> removes deprecation warning.
  • Fixed value passed into fontawesome icon. Was a number, required a string.
  • Changed absolute link from Link to a. Link only allows relative links.
  • Updated Tooltip to take in className property. Removed nested button.

Relates to #1172

- Updated `StaticQuery` to `useStaticQuery` -> removes deprecation warning.
- Fixed value passed into fontawesome icon. Was a number, required a string.
- Changed absolute link from `Link` to `a`. `Link` only allows relative links.
- Updated `Tooltip` to take in `className` property. Removed nested button.
@BrookJeynes BrookJeynes requested a review from JackDevAU January 2, 2024 04:54
@BrookJeynes BrookJeynes enabled auto-merge (squash) January 2, 2024 04:57
@BrookJeynes BrookJeynes merged commit 87f9785 into main Jan 2, 2024
4 checks passed
@BrookJeynes BrookJeynes deleted the fixing-browser-errors branch January 2, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants